sourcery-ai[bot]
commented
1 year ago Sourcery Code Quality Report
β Merging this PR will increase code quality in the affected files by 0.05%.
| Quality metrics | Before | After | Change |
|---|---|---|---|
| Complexity | 6.15 β | 5.95 β | -0.20 π |
| Method Length | 160.43 π | 160.40 π | -0.03 π |
| Working memory | 10.21 π | 10.21 π | 0.00 |
| Quality | 55.95% π | 56.00% π | 0.05% π |
| Other metrics | Before | After | Change |
|---|---|---|---|
| Lines | 5903 | 6451 | 548 |
| Changed files | Quality Before | Quality After | Quality Change |
|---|---|---|---|
| setup.py | 66.88% π | 66.88% π | 0.00% |
| examples/05_glm_second_level/plot_oasis.py | 50.50% π | 50.50% π | 0.00% |
| examples/05_glm_second_level/plot_proportion_activated_voxels.py | 69.83% π | 69.83% π | 0.00% |
| examples/05_glm_second_level/plot_second_level_association_test.py | 49.85% π | 49.81% π | -0.04% π |
| examples/05_glm_second_level/plot_second_level_design_matrix.py | 70.41% π | 70.67% π | 0.26% π |
| examples/05_glm_second_level/plot_second_level_one_sample_test.py | 41.52% π | 41.52% π | 0.00% |
| examples/05_glm_second_level/plot_second_level_two_sample_test.py | 45.78% π | 45.78% π | 0.00% |
| examples/05_glm_second_level/plot_thresholding.py | 56.38% π | 56.03% π | -0.35% π |
| examples/06_manipulating_images/plot_affine_transformation.py | 44.90% π | 44.90% π | 0.00% |
| examples/06_manipulating_images/plot_compare_mean_image.py | 81.23% β | 80.94% β | -0.29% π |
| examples/06_manipulating_images/plot_extract_regions_labels_image.py | 74.67% π | 74.67% π | 0.00% |
| examples/06_manipulating_images/plot_extract_rois_smith_atlas.py | 63.83% π | 63.83% π | 0.00% |
| examples/06_manipulating_images/plot_extract_rois_statistical_maps.py | 67.55% π | 67.55% π | 0.00% |
| examples/06_manipulating_images/plot_mask_computation.py | 48.34% π | 47.96% π | -0.38% π |
| examples/06_manipulating_images/plot_negate_image.py | 80.79% β | 80.79% β | 0.00% |
| examples/06_manipulating_images/plot_nifti_labels_simple.py | 65.65% π | 65.56% π | -0.09% π |
| examples/06_manipulating_images/plot_nifti_simple.py | 59.74% π | 59.67% π | -0.07% π |
| examples/06_manipulating_images/plot_resample_to_template.py | 59.41% π | 55.36% π | -4.05% π |
| examples/06_manipulating_images/plot_roi_extraction.py | 36.87% π | 36.86% π | -0.01% π |
| examples/06_manipulating_images/plot_smooth_mean_image.py | 80.68% β | 80.53% β | -0.15% π |
| maint_tools/show-python-packages-versions.py | 88.79% β | 87.58% β | -1.21% π |
| nilearn/image/__init__.py | 62.81% π | 62.81% π | 0.00% |
| nilearn/image/image.py | 57.01% π | 56.89% π | -0.12% π |
| nilearn/image/resampling.py | 28.56% π | 29.25% π | 0.69% π |
| nilearn/image/tests/test_image.py | 65.04% π | 65.10% π | 0.06% π |
| nilearn/image/tests/test_resampling.py | 61.73% π | 61.74% π | 0.01% π |
Here are some functions in these files that still need a tune-up:
| File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
|---|---|---|---|---|---|---|
| nilearn/image/resampling.py | resample_img | 56 β | 904 β | 27 β | 3.65% β | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| nilearn/image/image.py | new_img_like | 31 π | 253 β | 12 π | 27.14% π | Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions |
| nilearn/image/resampling.py | reorder_img | 10 π | 409 β | 15 π | 33.36% π | Try splitting into smaller methods. Extract out complex expressions |
| nilearn/image/image.py | _smooth_array | 18 π | 216 β | 11 π | 38.94% π | Try splitting into smaller methods. Extract out complex expressions |
| nilearn/image/image.py | clean_img | 7 β | 200 π | 20 β | 39.23% π | Try splitting into smaller methods. Extract out complex expressions |
Legend and Explanation
The emojis denote the absolute quality of the code:
- β excellent
- π good
- π poor
- β very poor
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
codecov-commenter
π @Remi-Gau Thanks for creating a PR!
Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.
Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
Closes #XXXX(see our documentation on PR structure)doc/changes/latest.rst(see our documentation on PR structure)For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed.