Closed Remi-Gau closed 1 year ago
👋 @Remi-Gau Thanks for creating a PR!
Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.
Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
Closes #XXXX
(see our documentation on PR structure)doc/changes/latest.rst
(see our documentation on PR structure)For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed.
Merging this PR leaves code quality unchanged.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 1.47 ⭐ | 1.47 ⭐ | 0.00 |
Method Length | 56.17 ⭐ | 56.17 ⭐ | 0.00 |
Working memory | 7.35 🙂 | 7.35 🙂 | 0.00 |
Quality | 75.28% ⭐ | 75.28% ⭐ | 0.00% |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 115 | 116 | 1 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
setup.py | 66.82% 🙂 | 66.82% 🙂 | 0.00% |
maint_tools/show-python-packages-versions.py | 85.99% ⭐ | 85.99% ⭐ | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|
The emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #24 (ceae4d0) into main (0b3de6e) will decrease coverage by
0.10%
. The diff coverage is91.79%
.:exclamation: Current head ceae4d0 differs from pull request most recent head 572d1e9. Consider uploading reports for the commit 572d1e9 to get more accurate results
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
- Coverage 91.43% 91.34% -0.10%
==========================================
Files 133 133
Lines 15470 15470
Branches 3207 3207
==========================================
- Hits 14145 14131 -14
- Misses 780 793 +13
- Partials 545 546 +1
Impacted Files | Coverage Δ | |
---|---|---|
nilearn/datasets/func.py | 78.05% <ø> (-0.26%) |
:arrow_down: |
nilearn/datasets/struct.py | 90.75% <ø> (ø) |
|
nilearn/decoding/space_net_solvers.py | 98.05% <ø> (ø) |
|
nilearn/decomposition/_base.py | 94.87% <ø> (ø) |
|
nilearn/decomposition/canica.py | 91.66% <ø> (ø) |
|
nilearn/image/__init__.py | 100.00% <ø> (ø) |
|
nilearn/image/image.py | 95.65% <ø> (ø) |
|
nilearn/image/resampling.py | 93.58% <ø> (ø) |
|
nilearn/input_data/__init__.py | 100.00% <ø> (ø) |
|
nilearn/input_data/base_masker.py | 100.00% <ø> (ø) |
|
... and 37 more |
... and 4 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
run test in random order to potentially detect test pollution