temp

[github-actions[bot]]

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• [ ] PR has an interpretable title.
• [ ] PR links to Github issue with mention "Closes #XXXX"
• [ ] Code is PEP8-compliant.
• [ ] Changelog or what's new entry in "doc/changes/latest.rst"
• [ ] (Bug fixes) There is at least one test that would fail under the original bug conditions.
• [ ] (New features) There is at least one unit test per new function / class.
• [ ] (New features) The new feature is demoed in at least one relevant example.

We will review it as quick as possible, feel free to ping us with questions if needed.

[ghost]

Review on Crocodile

[sourcery-ai[bot]]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.40%.

Quality metrics	Before	After	Change
Complexity	10.37 🙂	11.16 🙂	0.79 👎
Method Length	131.81 😞	133.71 😞	1.90 👎
Working memory	12.92 😞	12.85 😞	-0.07 👍
Quality	52.35% 🙂	51.95% 🙂	-0.40% 👎

Other metrics	Before	After	Change
Lines	9112	10306	1194

Changed files	Quality Before	Quality After	Quality Change
nilearn/decoding/__init__.py	86.05% ⭐	86.05% ⭐	0.00%
nilearn/decoding/decoder.py	41.44% 😞	41.38% 😞	-0.06% 👎
nilearn/decoding/fista.py	14.28% ⛔	14.04% ⛔	-0.24% 👎
nilearn/decoding/objective_functions.py	77.42% ⭐	77.37% ⭐	-0.05% 👎
nilearn/decoding/proximal_operators.py	29.17% 😞	29.18% 😞	0.01% 👍
nilearn/decoding/searchlight.py	60.86% 🙂	60.42% 🙂	-0.44% 👎
nilearn/decoding/space_net.py	35.72% 😞	35.48% 😞	-0.24% 👎
nilearn/decoding/space_net_solvers.py	60.64% 🙂	60.45% 🙂	-0.19% 👎
nilearn/decoding/tests/simulate_graph_net_data.py	41.96% 😞	41.96% 😞	0.00%
nilearn/decoding/tests/test_decoder.py	57.24% 🙂	57.24% 🙂	0.00%
nilearn/decoding/tests/test_fista.py	55.39% 🙂	54.05% 🙂	-1.34% 👎
nilearn/decoding/tests/test_graph_net.py	70.27% 🙂	71.38% 🙂	1.11% 👍
nilearn/decoding/tests/test_objective_functions.py	80.36% ⭐	80.36% ⭐	0.00%
nilearn/decoding/tests/test_operators.py	65.39% 🙂	65.39% 🙂	0.00%
nilearn/decoding/tests/test_same_api.py	65.32% 🙂	65.32% 🙂	0.00%
nilearn/decoding/tests/test_searchlight.py	40.96% 😞	40.96% 😞	0.00%
nilearn/decoding/tests/test_sklearn_compatibility.py	64.04% 🙂	63.74% 🙂	-0.30% 👎
nilearn/decoding/tests/test_space_net.py	72.59% 🙂	72.49% 🙂	-0.10% 👎
nilearn/decoding/tests/test_tv.py	72.72% 🙂	72.72% 🙂	0.00%
nilearn/decomposition/_base.py	57.66% 🙂	57.63% 🙂	-0.03% 👎
nilearn/decomposition/_multi_pca.py	64.67% 🙂	64.67% 🙂	0.00%
nilearn/decomposition/canica.py	51.20% 🙂	51.20% 🙂	0.00%
nilearn/decomposition/dict_learning.py	62.73% 🙂	62.73% 🙂	0.00%
nilearn/glm/second_level/second_level.py	49.67% 😞	49.07% 😞	-0.60% 👎
nilearn/glm/tests/test_second_level.py	61.73% 🙂	60.96% 🙂	-0.77% 👎
nilearn/glm/tests/test_utils.py	71.32% 🙂	71.24% 🙂	-0.08% 👎
nilearn/mass_univariate/permuted_least_squares.py	4.23% ⛔	3.57% ⛔	-0.66% 👎
nilearn/mass_univariate/tests/test_permuted_least_squares.py	55.69% 🙂	54.14% 🙂	-1.55% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nilearn/mass_univariate/permuted_least_squares.py	permuted_ols	84 ⛔	1371 ⛔	30 ⛔	1.30% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nilearn/decoding/proximal_operators.py	_prox_tvl1	48 ⛔	486 ⛔	28 ⛔	5.31% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nilearn/decoding/space_net.py	BaseSpaceNet.fit	41 ⛔	841 ⛔	28 ⛔	6.46% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nilearn/decoding/space_net.py	path_scores	36 ⛔	549 ⛔	37 ⛔	7.48% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nilearn/decoding/fista.py	mfista	40 ⛔	422 ⛔	29 ⛔	7.64% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

[codecov-commenter]

Codecov Report

Merging #4 (2ee9bc1) into main (3e4652f) will increase coverage by 23.59%. The diff coverage is 89.71%.

@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
+ Coverage   67.40%   91.00%   +23.59%     
===========================================
  Files         133      133               
  Lines       15286    15356       +70     
  Branches     2937     3033       +96     
===========================================
+ Hits        10304    13975     +3671     
+ Misses       4546      817     -3729     
- Partials      436      564      +128     

Impacted Files	Coverage Δ
nilearn/decomposition/_base.py	94.87% <ø> (ø)
nilearn/decomposition/_multi_pca.py	100.00% <ø> (ø)
nilearn/decomposition/canica.py	91.66% <ø> (ø)
nilearn/decomposition/dict_learning.py	89.06% <ø> (ø)
nilearn/decoding/proximal_operators.py	71.81% <73.07%> (ø)
nilearn/decoding/space_net.py	88.21% <81.25%> (ø)
nilearn/decoding/fista.py	87.65% <85.71%> (ø)
nilearn/decoding/objective_functions.py	86.58% <86.66%> (-0.17%)	:arrow_down:
nilearn/decoding/decoder.py	95.97% <97.77%> (ø)
nilearn/decoding/__init__.py	100.00% <100.00%> (ø)
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.