RemiRigal / Overseerr-Assistant

Browser extension for Overseerr that embeds buttons into IMDb and TMDB web pages to easily request movies and tv shows.
MIT License
104 stars 10 forks source link

Access for non-owners of Overseerr- or Plex-instance #35

Open achmetinternet opened 1 year ago

achmetinternet commented 1 year ago

Hi there, a friend of mine is a user on my plex server and uses his credentials to log onto Overseerr. The add-on though requires an API key to log in. I know where it can be found but not every user. Maybe you could add something on the manual where to find it. Or change the login to the plex login :)

RemiRigal commented 1 year ago

Hello @achmetinternet, thank you for opening an issue, this is an interesting feedback.

It's not possible to get an api key for your friend unfortunately. This issue in Overseerr repository points out the need for api keys for regular users. It's six month old though, so not likely to be implemented soon.

As you pointed out, a reasonable solution would be to change the login to the Plex OAuth login (or give a choice between the two). The drawback of this approach is that the the sessions will expire frequently, but of course it provides extra security.

Hollander-1908 commented 1 year ago

Hi there, a friend of mine is a user on my plex server and uses his credentials to log onto Overseerr. The add-on though requires an API key to log in. I know where it can be found but not every user. Maybe you could add something on the manual where to find it. Or change the login to the plex login :)

So there is a way to find the Overseerr ApiKey for a specific user other than the owner? Can you tell me how? Would be very useful. Thanks!

alchemyyy commented 8 months ago

Hello @achmetinternet, thank you for opening an issue, this is an interesting feedback.

It's not possible to get an api key for your friend unfortunately. This issue in Overseerr repository points out the need for api keys for regular users. It's six month old though, so not likely to be implemented soon.

As you pointed out, a reasonable solution would be to change the login to the Plex OAuth login (or give a choice between the two). The drawback of this approach is that the the sessions will expire frequently, but of course it provides extra security.

I just tried this out with jellyseerr and jellyfin accounts, it was pretty easy to do and seems to be a pretty transparent change. I haven't had any issues so far. simply having the session ID cookie appears to do the job.

I'm just hacked this out really quick but I could make the beginnings of a PR if you'd like. It was a rather minor change though, and I imagine you'd like to approach with a universal solution for plex and jellyfin.

matijaerceg commented 2 months ago

Just adding a +1 for this because I'd love for my cinemaphile friends to be able to add requests directly from various sites without visiting overseer and without me doling out the API key

Like, what if the extension was just a tiny iframe of the instance of Overseerr, so that if they're logged in to Overseer, the iframe would just need to send along a generic request, regardless of how they're logged in. Sorry if that's a ridiculous idea.