RemiRigal / Plex-Auto-Languages

Automated language selection for Plex TV Shows !
MIT License
428 stars 16 forks source link

"All / Next" setting doesn't work #12

Closed Manujito closed 2 years ago

Manujito commented 2 years ago

The setting doesn't work for me. It always changes all the episodes in the entire season/show even if I put "next" in the config file.

RemiRigal commented 2 years ago

Hi @Manujito, I saw your comment on Reddit, as you said it's better to discuss here. Thank you for opening an issue !

I can't reproduce the issue on my end. Just to be sure, double check the name of the parameter in your config file as well as the value, it's also case sensitive so "Next" or "NEXT" do not work.

If the issue is still there, can you give me additional information:

Manujito commented 2 years ago

I'm on version 1.25.9.5721 of Plex. I'm running it natively with Python, version 3.10.1.

I tried your command for the PlexAPI version but it didn't work, it just returns: "Error while finding module specification for 'import plexapi; print(plexapi.version)' (ModuleNotFoundError: No module named 'import plexapi; print(plexapi')" Sounds like a syntax error, not sure what to change.

EDIT: I also checked my config file and it looks like this:

plexautolanguages: update_level: "season" update_strategy: "next" trigger_on_play: true trigger_on_activity: false

EDIT2: forgot to mention, I'm testing this on Attack on Titan S01 with dual language "IT/JP" and dual subtitle "IT Forced/IT".

RemiRigal commented 2 years ago

My bad, the command is (-c instead of -m): python3 -c "import plexapi; print(plexapi.__version__)"

I assume that you have spaces/tab before every parameter except plexautolanguages right ? The formatting is not great in GitHub.

Manujito commented 2 years ago

Sorry for the long wait. PlexAPI version is 4.10.1.

I just updated Plex-Auto-Languages and the result is the same. When the update happens, even if I have "next" in my config file, the entire season gets changed.

As for the formatting, that's correct. I used the examples files and customized it keeping formatting intact.

RemiRigal commented 2 years ago

The range of episodes is now logged for every language change. You should have something like the following:

2022-04-30 13:22:21,430 [INFO] Language update: Show: Attack on Titan | User: xxxx | Audio: Italian (AC3 5.1) | Subtitles: Italian (SRT) | Updated episodes: 21/21 (S01E05 - S01E25)

With (S01E05 - S01E25) indicating the episodes that have been checked for potential language update. Can you try watching something like S01E04 and see if PlexAutoLanguages still tries to update S01E01 ?

If the issue is still there, try to set the update_strategy parameter with the environment variable UPDATE_STRATEGY, you will have an explicit log on startup if this is picked up correctly.

Manujito commented 2 years ago

Ok, nevermind. This is completely my fault for not understanding what that option meant. I thought it meant that "next" would only change the next episode, singular, and that "all" would change all the remaining episodes.

I'm sorry for wasting your time, the option works as expected.

RemiRigal commented 2 years ago

No worries, the parameter could have been described better !

Would you like an option to update only the next episode ?

Manujito commented 2 years ago

It's absolutely not a priority and I'm not sure I would even use it, but thanks for your interest. I like to test things out as much as I can so I just thought the option was not working as intended.

Now that I know what it does, i'm actually using the "all" option myself.

RemiRigal commented 2 years ago

I'm closing this issue then. Feel free to reopen it if you need this feature in the future.

Thank you for opening an issue !