search

RemiRigal / Plex-Auto-Languages

Automated language selection for Plex TV Shows !
MIT License
428 stars 16 forks source link

Only change the subtitle if the Subtitle language exists #17

Open Eagle1337 opened 2 years ago

Eagle1337 commented 2 years ago

Example: Season 1 Available Languages: English Season 2 Available Languages: English, Japanese

If you go to season to and change the subtitle language to Japanese it makes it so that Season 1 gets no subtitle language. It makes things a pain when you have different releases for some shows with multiple seasons. Ideally you'd be able to change the entire show's subtitles (and when you make a change in the season that's different it wouldn't wipe the old settings due to the language not existing.)

RemiRigal commented 2 years ago

The current behavior is to unselect the currently selected stream if it does not match the one you are watching, I see how this can be a pain in your case.

The issue is that if you have for example this:

If I change the episode 1 to French/French Forced and the corresponding subtitle does not exists in the episode 2, it may not be ideal to let the English Forced subtitles selected.

What can be done is either set a configuration parameter, something like unselect_on_mismatch, or unselect only if the stream is a forced subtitle, which is the most subject to change. What do you think ?

Eagle1337 commented 2 years ago

Like with anime for example, especially with tracks that have multiple subtitle tracks, you'll get things like english/EN (tag): XX subtitles No Honorifics English/ENM (tag): Honorifics

others like with use japanese or various other bits. and selecting an ENM tag in cases where it doesnt's exist completely kills all subtitle track defaults and defaults to none.

Animorphs commented 1 year ago

Bumping this issue, having the same experience. In my case I have the following setup:

Season 1:

Season 2:

If season 1 is watched with English audio and forced subtitles, then season 2 is changed by PAL to Japanese audio and no subtitles. This scenario is very common in anime as English audio is usually released after the Japanese audio, so experiencing this issue a fair bit.

Expected behavior would be to play the Japanese audio + English subtitles if there is no other option available.

Eagle1337 commented 7 months ago

As a belated update thing. there was a fork by Jusremo, that didn't swap between, it just left things if they were in English, made it great when you had some fun with different english language tagged subs but not fully through, such as English Middle Ages and etc, but the guy killed the repo, I have a version via git clone as it's what I mostly use.