Data labels are not always visible

Remimstr / COVID-19-globeview

3 stars 1 forks source link

Data labels are not always visible #1

Closed globau closed 4 years ago

globau commented 4 years ago

Unless the point is in the centre of the viewport, data labels are quite often not visible.

Steps to reproduce:

Align the globe so the equator is vertically centred
Try to view the data for an Australian city

Expected:

data labels should always be completely visible

Actual:

hugetiny commented 4 years ago

This problem is caused by echarts. I think disable the tooltips and manually shows a pop-up could be a solution for this.

Remimstr commented 4 years ago

@hugetiny I actually tried that in an earlier build but I ran into an even worse bug where the whole chart would glitch out when I ran setOption with the new options. I'll make a new branch to show you what I mean.

Remimstr commented 4 years ago

@hugetiny Actually I don't know what I'm talking about, it's just a hover event, there's no need to set any options... I'll make a new branch for this feature instead

hugetiny commented 4 years ago

I found my solution.Tomorrow I will make a pr the event should be 'mousemove'

Remimstr commented 4 years ago

Hey @hugetiny, I already implemented a fix for this issue 89b3ed6a18008f104acb8441bcb9b91d71605bc0 I'm sorry if you really wanted to do it, I just really wanted to get rid of the broken tooltips as quickly as I could.

hugetiny commented 4 years ago

@Remimstr It's OK.I will continously improve this project.