RemkoDuursma / plantecophys

Analysing and Modelling Leaf Gas Exchange Data in R
http://remkoduursma.github.io/plantecophys
16 stars 7 forks source link

solar radiation term in heat budget #5

Open mrke opened 10 months ago

mrke commented 10 months ago

https://github.com/RemkoDuursma/plantecophys/blob/c9749828041f10ca47c6691436678e0a5632cfb8/R/LeafEnergyBalance.R#L161

Hi Remko, I was comparing the predictions of leaf temperature from FindTleaf with other approaches and found that FindTleaf predicted way too high. I think it is because you multiply the incoming solar by two at the line referenced above. I think instead, because only one side gets the full blast, and the other side should get what is reflected from whatever surface is below. All the best, Mike

mrke commented 10 months ago

sorry I missed a bit - should have said 'I think instead, you should either just multiply by 1 or be explicit about reflected solar hitting the underside ...'

RemkoDuursma commented 10 months ago

Hi Mike,

thanks for the info. We never really tested the Tleaf predictionsnin detail, so i am not surprised there is some error. Thanks for letting me know.

Are you able to make a pull request with the suggested change? Otherwise i can fix it soon. I have left science so it may take a little longer unfortunately.

greetings Remko

On Mon, 11 Dec 2023, 21:20 Michael Kearney, @.***> wrote:

https://github.com/RemkoDuursma/plantecophys/blob/c9749828041f10ca47c6691436678e0a5632cfb8/R/LeafEnergyBalance.R#L161

Hi Remko, I was comparing the predictions of leaf temperature from FindTleaf with other approaches and found that FindTleaf predicted way too high. I think it is because you multiply the incoming solar by two at the line referenced above. I think instead, because only one side gets the full blast, and the other side should get what is reflected from whatever surface is below. All the best, Mike

— Reply to this email directly, view it on GitHub https://github.com/RemkoDuursma/plantecophys/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADOOCW2VT3DJI2BMNDO6HTYI5THHAVCNFSM6AAAAABAQLDCH6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZTMNBWGA2DSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RemkoDuursma commented 10 months ago

right thanks

On Mon, 11 Dec 2023, 21:22 Michael Kearney, @.***> wrote:

sorry I missed a bit - should have said 'I think instead, you should either just multiply by 1 or be explicit about reflected solar hitting the underside ...'

— Reply to this email directly, view it on GitHub https://github.com/RemkoDuursma/plantecophys/issues/5#issuecomment-1850828966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADOOCRVQBTIWMBHIPCDZELYI5TRDAVCNFSM6AAAAABAQLDCH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQHAZDQOJWGY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

mrke commented 10 months ago

Actually, I take it back - I think the x2 might be because you are assuming 0.5 of the global solar is PAR and so multiplying the PPFD by two

s-kganz commented 8 months ago

Hi,

I'm also finding that FindTLeaf returns too high of temperatures. The supplemental of this paper reports the same thing, especially when leaf size is large. I think the issue is coming from the treatment of longwave radiation:

https://github.com/RemkoDuursma/plantecophys/blob/c9749828041f10ca47c6691436678e0a5632cfb8/R/LeafEnergyBalance.R#L156-L167

My understanding about longwave radiation is that:

  1. Both sides of the leaf are radiating energy
  2. Longwave radiation is emitted by air in all directions, so both sides of the leaf receive the incoming flux

This would translate to multiplying both Rlongup and (1 - ema)*Boltz*Tk(Tair)^4 by 2 in the above snippet. I've been working on some energy balance models that are formulated similarly, and I find that this results in more reasonable (i.e. cooler) temperatures. I don't have permission to share data from that project, but if this is of interest I could find something in the literature to compare on.