search

Remora / Remora.Discord

A data-oriented C# Discord library, focused on high-performance concurrency and robust design.
GNU Lesser General Public License v3.0
246 stars 44 forks source link

feat: implement abstraction level for feedback service #290

Closed Inerska closed 1 year ago

Inerska commented 1 year ago

This PR implements an higher abstraction level for FeedbackService, it will allow people to mock FeedbackService easier.

Hakxsorus commented 1 year ago

https://github.com/Remora/Remora.Discord/blob/main/Remora.Discord.Commands/Extensions/ServiceCollectionExtensions.cs#L249

Should the abstraction not also be registered here?

MazeXP commented 1 year ago

https://github.com/Remora/Remora.Discord/blob/main/Remora.Discord.Commands/Extensions/ServiceCollectionExtensions.cs#L249

Should the abstraction not also be registered here?

You are totally right on this one!