search

Remora / Remora.Discord

A data-oriented C# Discord library, focused on high-performance concurrency and robust design.
GNU Lesser General Public License v3.0
246 stars 44 forks source link

Fix/user apps #336

Closed VelvetToroyashi closed 2 months ago

Nihlus commented 2 months ago

You're still missing test payloads for the added entities and tests for those.

VelvetToroyashi commented 2 months ago

For interaction objects? Or the application object

Nihlus commented 2 months ago

The JSON payloads under test haven't been updated for existing entities (IApplicationCommand) and no new JSON payloads have been added for new types (like IMessageInteractionMetadata). Check your changed and added entities from both this PR and #327.

Nihlus commented 2 months ago

You've got a few alerts remaining along with some merge conflicts that came in as part of polls - other than that, things seem ready to go.

VelvetToroyashi commented 2 months ago

@Nihlus should be good to go now