search

Remote-Text / remote-text-ios-client

The iOS/iPadOS app for Remote Text
1 stars 0 forks source link

Preview and share files #4

Closed simanerush closed 1 year ago

simanerush commented 1 year ago

should this be merged into main?

Samasaur1 commented 1 year ago

right now it only works for PDF previews, and HTML previews give you an empty PDF. we'd have to fix that first but then yeah

Samasaur1 commented 1 year ago

i'm also not super happy with where I have the preview button, because it implies that you're previewing the version of the file in the editor and not the last saved version, which is the truth

Samasaur1 commented 1 year ago

The latest commit I just pushed resolves my last concern — maybe not perfectly, but good enough to merge.

The other thing that was suggested by one of my coworkers was that we have a "Save & Preview" button, so that you can make changes, save them, and preview them, all without returning to the file list screen. They suggested either separate buttons or some sort of drop-down menu on the Save button

Samasaur1 commented 1 year ago

That could be a separate change made later, though