search

RemoteMetering / geteventstore-promise

An EventStore http+tcp wrapper package
MIT License
31 stars 17 forks source link

Unify 'onEventAppeared' and 'onEvent' signatures. #76

Closed adebisi-fa closed 4 years ago

adebisi-fa commented 4 years ago

onEvent has the signature (subscription, event) => { }. onEventAppeared should also be (subscription, event) => {} and not (event) => {}.

This is as defined in the EventAppearedCallback signature, accepted by both the connection.subscribeToStream(...) and connection.subscribeToStreamFrom(...) methods in the get-eventstore-client library.

mmuller99 commented 4 years ago

Hi @adebisi-fa, thanks again for another contribution.

Could you please remove the now unused "EventAppearedCallback" from the node-eventstore-client import as well as move the MappedEventAppearedCallback below its fellow subscription based defs?

Thanks

adebisi-fa commented 4 years ago

Dear @mmuller99,

Thank you for the review. The changes have been effected, as requested.

We do appreciate your efforts working on and maintaining this project. It rocks!

Warm regards, please.

mmuller99 commented 4 years ago

Thanks a lot @adebisi-fa 👊