RemoteMetering / geteventstore-promise

An EventStore http+tcp wrapper package
MIT License
31 stars 17 forks source link

Fix typo, auth headers and fix dependency #89

Closed maniolias closed 3 years ago

maniolias commented 3 years ago

Issues

Typo

I found a typo for resolveLinkTos options for persistentSubscriptions.assert method. The parameters is written as resolveLinkTos in the index.d.ts but resolveLinktos is used in the js code. I renamed it to resolveLinkTos to align it with HTTP API and other methods of this package (even if eventstore returns a typo in their response). The result of this typo was that the resolve options was always false on the created persistent subscriptions when using typescript.

LinkFunctions (ackAll, nack...)

When running tests 401 http response was throw because of missing auth headers during linked actions (eg. ackAll).

Dependency

Update dependency to node-eventstore-client to version 0.2.18.