RemoteMetering / geteventstore-promise

An EventStore http+tcp wrapper package

MIT License

31 stars 17 forks source link

[Feature] Projections - config + create projection with trackEmittedStreams #92

Closed maniolias closed 3 years ago

maniolias commented 3 years ago

Issues

TrackEmittedStreams

The current version of geteventstore-promise does not allow to set trackEmittedStreams parameter to true. This feature is usefull when we want to delete a projection and it's emitted streams.

GetInfo

To be able to test and validate the previous feature I've added the projection getInfo feature to add configuration informations.

maniolias commented 3 years ago

Hi,

Thanks for your feedback. I had to do more changes than expected. We cannot edit trackEmittedStreams configuration without calling the config route of the projection and we cannot do it when the projection is still running. For now I removed the editing of trackEmittedStreams parameters and will look to create the feature in a next PR.

maniolias commented 3 years ago

Of course. My bad I missed this part. I'll look to do it ASAP.

maniolias commented 3 years ago

I just did the changes you asks for. Hope it's good for you :).

maniolias commented 3 years ago

@mmuller99 thanks for your feedback. I did the expected changes in the README

mmuller99 commented 3 years ago

@maniolias don't see the commit, can you please check?

maniolias commented 3 years ago

Sorry, I didn't add it so push did nothing. It should be good now.