search

RemoteMetering / geteventstore-promise

An EventStore http+tcp wrapper package
MIT License
31 stars 17 forks source link

[Feature] connect to persistent subscription #98

Open jacekzlowocki opened 3 years ago

jacekzlowocki commented 3 years ago

This PR contains two changes:

  1. The main one: support for connecting to Persistent Subscriptions with TCP Client
  2. Chore:
    • added missing @types/generic-pool package
    • replaced yarn.lock with package-lock.json - this is done because yarn.lock contains unreachable registry (private RemoteMetering registry?)
mmuller99 commented 3 years ago

Hi @jacekzlowocki, thanks for the good looking PR, this is much needed functionality. Apologies for only getting to it now, was on a little vacation. Please see comments below:

"- replaced yarn.lock with package-lock.json - this is done because yarn.lock contains unreachable registry (private RemoteMetering registry?) Sorry about that, if you pull master again, the global registry yarn.lock file should function again"

Would it be possible to add the options and tests for the user to pass in the bufferSize and autoAck params and handle accordingly?