RemotePixel / search.remotepixel.ca

New version of SatelliteSearch
https://search.remotepixel.ca
BSD 3-Clause "New" or "Revised" License
5 stars 0 forks source link

Portuguese ? #1

Open vincentsarago opened 6 years ago

vincentsarago commented 6 years ago

A third of remotepixel.ca traffic comes from Brazil. I think it will be great to offer this project in Portugues.

I think the only part that need to be translated is the help section https://github.com/RemotePixel/search.remotepixel.ca/blob/master/index.html#L50-L137

george-silva commented 6 years ago

Hi Vincent! First of all, great work here!

I've taken a look at the project and my take is that it's just plain javascript. It's pretty rare these days :smile: . Great work!

When I work with i18n, usually there is a translation file, JSON or whatever, that we use to hold the all the strings and we can then just create new locales for it.

There are a few projects that are excellent for this. In my perspective a plain and simple one would do wonders for this project. My suggestion is Polyglot JS (http://airbnb.io/polyglot.js/).

If you'd like, I can give it a shot integration it in the project and then creating the translation files.

What are your thoughts?

george-silva commented 6 years ago

Polyglot.js will be pretty hard to use to output these strings. I would like to hear from ya what are your ideas regarding this. Creating a new index.html under a locales folder might work, but how are you going to choose what you'll serve?

Also, it will be a PITA to maintain different HTML code.

vincentsarago commented 6 years ago

Hi @george-silva, Well I've taken a quick look to Polyglot, and I feel the same it might be a bit overkill right now!

FYI, the web site is self hosted on AWS S3, so there is no Real server (AWS S3 + Cloudfront).

I don't want to go to far in the integration and I feel just translating the help section will be already a good thing for the users.

Here is what I had in mind capture d ecran 2018-03-03 a 14 13 49

I'm not a frontend/backend dev, that's why the site is in pure js+css. I know it's not the best way to do it those days :-)