RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
235 stars 102 forks source link

Yet another "station stops transmitting on unload" issue #345

Closed wisq closed 9 years ago

wisq commented 9 years ago

Okay, so I don't know if this is related to #338, and/or my previous report #232, but this one seems to be more severe than either of those — it involves the unloaded ship losing all RemoteTech capabilties altogether, not just the status as a command base.

Sequence of events:

  1. Fire up KSP, load savegame, tracking station, open my space station
  2. Build and launch a new unmanned ship using ExtraPlanetaryLaunchpads
  3. Pilot that ship until I get far enough from the station for it to unload
  4. Station is no longer transmitting whatsoever — no red dot, no communications lines

Other notes:

Files:

Let me know if you need anything else. It's not a huge problem for me right now since I can just switch back to the station and back to my ship again if necessary.

SirDiazo commented 9 years ago

Note I have not actually loaded this issue to look at it, but I would suspect how EL spawns ships is the culprit. (I had to figure this out for action groups and AGX)

When you build an EL ship, the ship spawns as a standalone vessel that once initialized immediately docks to the launch pad that spawned it.

My first guess would be because the vessel exists for such a short time (I'm not sure even a full update has time to happen) that the RT stuff never has time to create it's stuff on the vessel before it docks to the launch pad and becomes part of the launch pad vessel.

wisq commented 9 years ago

Interesting. But if that were the case, wouldn't it be that the launched ship's communications would be what fails, rather than the station's? Unless the error shifts from the launched ship to the station because of the docking.

Or maybe the EPL "release" system doesn't properly separate the two — I don't know enough about modding to know if this makes sense, but if there are hooks tied to a vessel / info stored on a vessel record, and there's something that needs to happen when one vessel becomes two (e.g. add a hook to both vessels / recalculate what antennae they have / etc.), and the EPL release system does it in an unexpected way, then RT wouldn't have the hooks / info it needs.

What's interesting is that I was only able to reproduce it when the launched vessel remained in-scene and the station moved out of scene — if I just left both of them by switching to another ship entirely, things seemed to still work okay. But maybe something was masking the problem.

SirDiazo commented 9 years ago

As far as I can tell, the EPL release is a standard undock.

Which is why I suspect the initial "load" of the vessel does not complete when it is spawned.

Having said that, I have no clue what the "-1" in the log is, this does nothing to explain that.

Peppie84 commented 9 years ago

Hi @wisq thanks for your report and your detailed video report :+1: Is the mod list from #338 your current mod list?

wisq commented 9 years ago

My mod list should still be broadly similar to the one in #232, plus or minus a couple at most. I made sure to open up CKAN in the video to get the most up-to-date list.

Most recent addition would be Fusebox (http://forum.kerbalspaceprogram.com/threads/50077).

If you'd like it transcribed into this report, let me know. Was hoping to save a little time, but I see now that it's not the most legible on YouTube. :)

Peppie84 commented 9 years ago

oh sorry, i skiped the first few seconds of the video. ok, hmm, it looks like that you play with "all" ksp mods :sweat_smile:

I'll try to reproduce ;)

wisq commented 9 years ago

Haha, yeah, sorry, I run quite a few. :) If there's any code you want me to run, or mods you want me to try removing, let me know.

Peppie84 commented 9 years ago

@wisq how can i fix the high power drain? drain

Peppie84 commented 9 years ago

ok i disabled the RT consumption. But now, after building your 'Inner Planets Probe' i can't move this probe :( do i something wrong? Even if i throttle up the ion engine, i can see that the engine is fireing but the probe doesn't move :(

screenshot60

wisq commented 9 years ago

Make sure to use "release" in the ExtraPlanetaryLaunchpads window, otherwise it's still docked to the station.

If that's still not working, then I'm not sure ... I've not had any problem releasing anything so far. Could maybe be a Kerbal Joint Reinforcement thing; I've had ships get stuck in the launchpad, but I thought Ferram resolved all those issues.

Peppie84 commented 9 years ago

jep, i clicked the release button on the EL window. but maybe is this another rt bug ... i'll look closer