search

RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
230 stars 103 forks source link

Release 1.4.0 #59

Closed wms closed 10 years ago

wms commented 10 years ago

Candidates for inclusion in next release are:

Please provide links to other commits that you think would be suitable for inclusion in 1.4.0

Pezmc commented 10 years ago

Some of the bug fixes coming in to this repo from Peppie23 look good. See #62, #60, #57

Starstrider42 commented 10 years ago

I think a fix to #63 should also be in anything we're calling a 0.23.5 release (thanks Peppie23 for noticing this wasn't issued yet). I think Cilph may have already fixed this as part of the refactor, in which case we can just copy it over.

Pezmc commented 10 years ago

Looks like Peppie has posted a pull request to fix that too: b1008d01c29817b2fcccba3dfa1e9c0a0fdcfdcc #64

Peppie84 commented 10 years ago

i already have some fixes here: https://github.com/Peppie23/RemoteTech2/commits/master later this day i will push theses as well

wms commented 10 years ago

@Peppie23 Thank you for these PR's, I'm going to start reviewing them now...

Starstrider42 commented 10 years ago

Out of curiosity, which issues/pulls will actually be counted as part of the 1.4.0 milestone?

wms commented 10 years ago

@Starstrider42 I'm listing the PRs that are planned for 1.4.0 right here so that they can be discussed. I'm going to stage them in the 'develop' branch, and then merge to master once everybody's happy.

Starstrider42 commented 10 years ago

Ah, so this is the only issue attached to to the milestone because it serves as a compilation. Got it.

Starstrider42 commented 10 years ago

I propose that #66 and #68 be considered for 1.4.0.

Peppie84 commented 10 years ago

hi, can you verify these changes from Jaidan's branche: https://github.com/Peppie23/RemoteTech2/commit/f44c245e756b9c9bb8904b1bf69f4c131cf71977

The FlightCore.cs Patch fixes the getThrust for the 23.5 NASA Engine parts.

wms commented 10 years ago

@Starstrider42 I've tagged those PRs for the next release.

@Peppie23 Can you move the .gitignore changes to a separate commit, then clean up the whitespace changes and remove commented lines when raising the PR?

Peppie84 commented 10 years ago

PR #74

Edit: The other fixes from the linked PR are from madadam that you already mentioned in your first post. Should i PR these changes too? (https://github.com/Jaidan/RemoteTech2/commit/43c16969d7924d8f43f1280b0c8656fdd93478c0 and https://github.com/Jaidan/RemoteTech2/commit/31400c4c641e39d4b09eebe29e86776fd72d9760)

wms commented 10 years ago

@Peppie23 I've been hacking around on madadam's fix for the last couple of hours - I'd really like to see if there's a way to retain the per-frame caching, but I'm think I'm going to have to give up on it...

Peppie84 commented 10 years ago

do you have any test cases for the per-frame caching? Probably i don't understand the issue itself but maybe i can help you.

The PR for Madadams fix is #75.

On my first branch i also had this fix for my local copy and i never got any 'vessel duplications' or 'dissapearing space centers' i think we should use this patch

wms commented 10 years ago

Load this save file - https://gist.github.com/3cbfc90ed7aa246da2ab, go to the Tracking Station and switch to the vessel named 'Duplication bug tester', and stage. By the time the sepatrons burn out, the two halves of the craft will be > 2.5km away and the other half will be unloaded.

Enter the map view, you should observe that the network graph rendering is broken, and Player.log is full of 'argument out of range' exceptions. Returning to the Space Center should result in a broken scene being displayed (note: this final step doesn't always happen; if it doesn't, reload the quicksave and try again)

This seems to be the hallmark of the bug; it doesn't always result in duplicate vessels, but if you do get duplicates, it seems to be because of this.

Applying this commit https://github.com/warrenseymour/RemoteTech/commit/5761d9328aa93bdf224b9a2e8ae96449d5d7f215 makes the bugged map and space center go away, but I haven't been able to prove that it fixes the duplicate vessel bug.

I went crazy trying to figure out why, but it appears that the SignalProcessors list is empty when accessed within the expression that's passed to the caching helper, but not when accessed outside of it. My c#/unity/ksp-fu is not strong enough to tackle this yet.

wms commented 10 years ago

Ok, just tried this out: my test procedure was to take a poorly designed SSTO to mach 1, let FAR aerodynamic stresses break it apart, and revert to runway.

With the 'official' release of 1.3.3, this would usually result in the camera getting placed in the void and instruments giving garbage readings. Returning to the space center would give an incorrectly rendered scene, and reloading the game would result in duplicate vessels in the tracking station.

With 1.4.0-RC1, none of these things occurred. Good sign I think, but given the indeterminate nature of the bug, only time (and your own testing) will tell.

Starstrider42 commented 10 years ago

I realize it's a little late in the dev cycle, but could a fix to #39 be included in 1.4.0? I just realized that it wasn't included in the recent maneuver node execution updates.

wms commented 10 years ago

@Starstrider42 Already taken care of in a slightly different way - see how the timing advance is always seeded with the current signal delay - https://github.com/warrenseymour/RemoteTech/commit/3fe2e00ae458f75006ee4a6d8ceae70992f16e8b

Peppie84 commented 10 years ago

I tried to find the bug with your save-file and the current master but after 20 tries nothing happend :( i'll do some tests with the official release 1.3.3 soon.

erendrake commented 10 years ago

alright guys, what is our punchlist to get a release? it doesnt appear that there are any really huge game breaking bugs and we can always ship another version if the community finds one.

anyone "no go" for launch?

Starstrider42 commented 10 years ago

My one "no go" issue is the documentation (#85), which I think is important to push out alongside the "rebirth" release. Warrenseymour gave it a quick read, but I'd like at least one more pair of eyes to look it over. Once that's done and this repo's gh-pages is up-to-date, I'll say "go".

pjf commented 10 years ago

I have a fix for #94 that I hope to PR as soon as I hear back from @pjf.

Yikes! I'm in transit right now (MEL-SYD-LAX-PDX), which is going to impede my ability to test things. So for the purposes of any release, it's best to assume I'm out of communications range. ;)

Starstrider42 commented 10 years ago

Ok, sorry to bug you then.

pjf commented 10 years ago

@Starstrider42 : Oh trust me, I'd be playing KSP if I could! I would be lying if I said I wasn't telling all my friends about how totally amazing the KSP (and RemoteTech in particular) modding community are! :D

I just didn't want to fall off the grid unexpectedly. :)

Starstrider42 commented 10 years ago

@RemoteTechnologiesGroup/owners, would it help to have another Google Hangout to discuss the release status of 1.4.0? I'm not sure any of us have a complete mailing list for the group, though...

erendrake commented 10 years ago

I would be interested in a hangout but with this weekend being fathers day i will have pretty limited time for it :(

On Fri, Jun 13, 2014 at 11:55 AM, Starstrider42 notifications@github.com wrote:

@RemoteTechnologiesGroup/owners https://github.com/orgs/RemoteTechnologiesGroup/teams/owners, would it help to have another Google Hangout to discuss the release status of 1.4.0? I'm not sure any of us have a complete mailing list for the group, though...

— Reply to this email directly or view it on GitHub https://github.com/RemoteTechnologiesGroup/RemoteTech/issues/59#issuecomment-46040911 .

wms commented 10 years ago

@RemoteTechnologiesGroup/owners I'm very happy with where we are now. I've drafted a forum post here - https://github.com/RemoteTechnologiesGroup/RemoteTech/wiki/Draft-Forum-Post

Once I get some approvals, I'll do the following:

Exciting!

Starstrider42 commented 10 years ago

@warrenseymour, couple of comments:

Thanks for working out the full credits list. I'll update the documentation accordingly.

Starstrider42 commented 10 years ago

Ask Cilph to update original thread (and lock if he is able to)

Only moderators can lock threads.

wms commented 10 years ago

@Starstrider42 Thanks. I've updated the wiki page. Provided you're satisfied with it, I'll get the ball rolling first thing tomorrow morning.

Starstrider42 commented 10 years ago

Looks good to me.

If you're releasing tomorrow, I guess that means I should treat the current documentation draft as final. I'll get that taken care of today.

wms commented 10 years ago

@RemoteTechnologiesGroup/owners Ok guys, 1.4.0 is out. I'm waiting for consent from 'carmics' and 'kommitz' to redistribute artwork that they've provided in the past so that the Curse project can be made public. I'm also waiting moderator approval of the announcement post on the mod showcase forum.

I'd like to thank you all for your awesome work in getting RT2 this far, there have been fantastic contributions from all concerned and I'm very excited about how far this team can take the project.