RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
233 stars 102 forks source link

CommNet still disabled despite enabling CommNet in RT settings #703

Closed KSP-TaxiService closed 7 years ago

KSP-TaxiService commented 7 years ago

Quoted from our KSP thread

Please know RT 1.8.1 also broke stock CommNet functionality, so you may wish to check it gets fixed as well. All was working right in RT 1.8.0, but with 1.8.1 need to have RT active to control probes; CommNet always shows lack of control whatever the settings in RT 1.8.1 start options.

Tested on the latest develop branch and KSP 1.2.1604

Reproduction steps: 1) Start a new game 2) Disable RT and enable CommNet in RT setting window at KSC scene 2) Build a probe with a stock antenna 3) Launch it

Expected result: Green status and full probe control in CommNet bar Actual result: No connection and limited probe control

I bet that our MM patches to the stock antennas are still in effect aka re-casting them as non-CommNet parts.

KSP-TaxiService commented 7 years ago

Yamori explained that our MM patch removes ModuleDataTransmitter from the stock antenna cfgs. The scenario of having ModuleDataTransmitter and ModuleRTAntenna in each stock antenna has unpleasant consequences.

However, the ModuleManager has one neat feature of dynamic module for both editor and flight scene.

KSP-TaxiService commented 7 years ago

In end, we decided to disable CommNet permanently when RT is installed in a player's KSP for two reasons: