Add RemoteTech config for the Communotron 88-88-V from Vens Stock Revamp

[zmpeg]

I added this change to fix the 88-88-V from vens stock revamp not having RemoteTech configs. Let me know if you would prefer me to create an issue or provide more detail in any way. This change only copies the config for the 88-88 to work for the 88-88-V. I can update with logs/modlist/persistent/screenshots if necessary.

O.S: Windows 10 64-bit KSP: 1.3 64-bit Problem: New antenna 88-88-V in Vens Stock Revamp does not have RemoteTech configs.

Reproduction steps: Install RemoteTech and Vens Stock Revamp. Hovering on the 88-88-V in VAB shows no RemoteTech info. Build a ship with the 88-88-V. Launch and fly. No RemoteTech connection.

[KSP-TaxiService]

Hi @zmpeg,

Thanks for letting us know about this new antenna part. Unfortunately, these changes in the PR are not working because the commDish name is Comm 88-88. I edited your codes to work, as shown below.

Kindly assist to update your codes on your repo and it will be reflected in this PR. Then, I can accept this into our repo.

// Communotron 88-88-V
@PART[commDishVSR]:NEEDS[RemoteTech]:AFTER[zzzVSRPathPatch]
{
    !MODULE[ModuleDataTransmitter] {}

    %MODULE[ModuleRTAntenna] {
        %Mode0DishRange = 0
        %Mode1DishRange = 40000000000
        %EnergyCost = 0.93
        %MaxQ = 2000
        %DishAngle = 0.06

        %TRANSMITTER {
            %PacketInterval = 0.3
            %PacketSize = 2
            %PacketResourceCost = 15.0
        }
    }
}

[zmpeg]

Ah yeah sorry about that. I had the correct name on my local install but forgot to change the antenna name in the PR. It's fixed now.

[KSP-TaxiService]

Actually, can you remove both @MODULE[ModuleDeployableAntenna] and %MODULE[ModuleSPUPassive] {} lines, as well as change to %MaxQ = 2000 (its description says no fairing so I lowered it)? I follow the current antenna patches in RemoteTech_VensStockRevamp.cfg.

[zmpeg]

@KSP-TaxiService Done. Curious why remove the deployable antenna part, as this antenna does have a deploy state?

[KSP-TaxiService]

Thanks! I will test the PR later. This antenna already has the deployment modules in VSR's cfg.

+PART[commDish] {
    @name = commDishVSR
    @title = Communotron 88-88-V
    @mass = 0.08
    @cost = 1400
    @description = The Communotron 88-88-V directional antenna allows for far more reliable communication at longer ranges than previous models. This is thanks in part to its patented parabolic folding design. ISPE's research team maintains it was not inspired by an umbrella, but clearly this one is based on an umbrella.  Looks like the manufacturer forgot to put the fairing on it.  Still, it's a little lighter and they're willing to discount the price as well.
    !mesh = DELETE
    !MODEL {}
    MODEL {
        model = VenStockRevamp/Squad/Parts/ScienceParts/88-88
        position = 0.0,0.07,0.0
    }
    %rescaleFactor = 1
    MODULE
    {
       name = ModuleAnimateGeneric
       animationName = pulseEmitLargeDishAntenna
       isOneShot = false
       startEventGUIName = Blink Lights
       endEventGUIName = Blink Lights
       allowManualControl = false
    }
    @MODULE[ModuleDeployableAntenna]
    {
        @pivotName = Armature_002
    }
    @MODULE[ModuleDataTransmitter] {
        %ProgressFxModules = 2
    }