Fix Ven's Stock Revamp Antennas

[Fumblesneeze]

These Modules seem to be required for the dishes to work.

[KSP-TaxiService]

Hi,

Without these modules, the revamped antennas do not work properly under RT om KSP 1.3?

[Fumblesneeze]

They did not work for me, latest CKAN install of RT. Dishrange in flight was 0.

[KSP-TaxiService]

Hmmm, it seems to work fine with RT develop and Stock Part Revamp 1.9.6 (without this PR). I can see the dish range is not 0. Can I see your output_log.txt please?

Edit: if possible, get the latest RT version 1.8.8 here to see if it works on your side.

[Fumblesneeze]

I won't have time to try until sometime next week.

[Fumblesneeze]

this is using 1.8.8

There seems to be an exception:

[EXC 21:27:37.668] KeyNotFoundException: The given key was not present in the dictionary.
    System.Collections.Generic.Dictionary`2[System.Guid,System.Collections.Generic.List`1[RemoteTech.SimpleTypes.NetworkLink`1[RemoteTech.ISatellite]]].get_Item (Guid key)
    RemoteTech.Modules.ModuleRTAntenna.get_Connected ()
    RemoteTech.Modules.ModuleRTAntenna.UpdateControlState ()
    RemoteTech.Modules.ModuleRTAntenna.FixedUpdate ()

Full log: https://1drv.ms/u/s!AmlEjzGbDToZg7VAA9aLVSAYRfkJyg (Antenna loaded with dish range from previous save, when I deactivated and activated it was 0 as in the picture).

[KSP-TaxiService]

Thanks. I compared the antenna cfgs of RT and third-party antennas and found the mentions of ModuleSPUPassive everywhere. Although it works with and without this tag on my side, I trust the other third-party cfgs and your words that this PR will solve the issue. I will proceed to accept this request (and you can keep your fix on RT 1.8.8).

Thanks for spotting this issue!

[Fumblesneeze]

Thanks,

As I said, I have no idea what this actually does, I’m not affiliated with either RT or Ven’s Stock Revamp. Maybe it’s some combination of other mods like Kopernicus that requires this module.

Thanks for merging though.