search

RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
233 stars 102 forks source link

Add cheat option to ignore line-of-sight requirements #743

Closed pianojosh closed 6 years ago

pianojosh commented 6 years ago

Without having to go full infinite-propellent which messes with a lot more game mechanics.

Ideally I'd also stop having InfinitePropellant also override line-of-sight but I don't want to confuse anyone who is used to using it. YOLO

cc @NathanKell

KSP-TaxiService commented 6 years ago

Hi,

I am surprised at the CheatOptions.InfinitePropellant choice for the LoS option. Technically, you do not add a new cheat option but correct the attribute misuse and expose it to Option window :p

Kindly help to change in NetworkManager.cs bool los = sat_a.HasLineOfSightWith(sat_b) || CheatOptions.InfinitePropellant || RTSettings.Instance.IgnoreLineOfSight; to bool los = sat_a.HasLineOfSightWith(sat_b) || RTSettings.Instance.IgnoreLineOfSight; in your pull request since CheatOptions.InfinitePropellant has no business with the LoS logic.

Then, I will accept this pull request.

Thanks!

pianojosh commented 6 years ago

@KSP-TaxiService Made that change. It'll confuse some people, but it's probably for the best longer-term.

KSP-TaxiService commented 6 years ago

Great! Thanks for your contribution.