RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
230 stars 103 forks source link

Set Assembly Version to same as ProductVersion #760

Closed Gordon-Dry closed 5 years ago

Gordon-Dry commented 5 years ago

A Kerbalism check fails, because:

RemoteTech.dll
      ProductName    : RemoteTech
      ProductVersion    : 1.8.13
      Assembly Version    : 1.8.0.0
PiezPiedPy commented 5 years ago

Extra bit of info Kerbalism checks the Assembly version is above 1.8.12 and since the RT dll Assembly version is set to 1.8.0 it gives a warning to the user that they are using a version earlier than 1.8.13 and should update.

KSP-TaxiService commented 5 years ago

This comment in the assembly file specifically says not to use revision numbers for Assembly Version.

This is what it shows if I include it.

RemoteTech v1.8.13.0 / v1.8.13

Do you know if it means for the current situation?

KSP-TaxiService commented 5 years ago

I propose a version increment to 1.9.0 to signify the distinction relationship between RT and Kerbalism.

But I am unable to justify the signification bump when there are no major changes between 1.8.13 and 1.9.0

Edit: actually, scrap it. I gonna to use 1.9.0 as RT needs few significant changes due to KSP 1.5.