RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
230 stars 103 forks source link

The new KSPAxisGroup controls are not suppported #794

Closed ncanceill closed 5 years ago

ncanceill commented 5 years ago

Impact The custom axis groups Custom01-Custom04 cannot be used with an unmanned vessel using RemoteTech 1.9.2 and KSP 1.7.1.2539

Fix I believe that the code handling the custom action groups could be expanded to also work with custom axis groups According to the docs, the key bindings are in GameSettings.AXIS_CUSTOM and the actions are KSPAxisGroup.Custom01-04 Notice that this does not affect the other (non-custom) axis groups, because they are already handled through the corresponding controls (pitch, yaw, throttle...)

KSP-TaxiService commented 5 years ago

Hi, I need more information about the custom axis groups C1 to C4. They don't seem to behave like custom action groups, and may be linked to the robotic controller.

How are C1 to C4 utilized in flight? On a light part, I assigned R, G and B to C1 to C3 and nothing happened when I turned on the light and pressed any of C1, C2 and C3.

ncanceill commented 5 years ago

Thanks for you reply @KSP-TaxiService

Sorry I was not clearer: the C1-C4 are axis groups, so they correspond to two functions (increment/decrement) and I have no idea how they should be used in the code, sorry...

I will try to look for more info on this and get back to you

ncanceill commented 5 years ago

... and to answer you second question:

Since KSP 1.7.1, axis groups (including C1-C4) are used to control a KSPAxisField (which is an extension of KSPField)

For instance, you can use them with the robotics parts from Breaking Ground: if you set axis group C1 to the "Target Extension" of a Hydraulic Cylinder, incrementing/decrementing C1 will move the Hydraulic Cylinder up and down

For a more general view on axis groups and KSPAxisField, see this

KSP-TaxiService commented 5 years ago

Do you have steps to utilize Custom Axis Groups in Editor?

I seem not to able to invoke or interact with a custom axis group in flight. The other axis groups like Main Throttle are easy to utilize like Z = full extension and X = zero extension on specific hydraulics

ncanceill commented 5 years ago

To use custom axis groups in flight, you must first bind them to the keys of your choice in KSP Settings.

For instance, I have bound Custom01 to NumPad7 (increment) and NumPad1 (decrement)

Then, I can create a craft with a Mk1 Lander Can and a Hydraulic Cylinder, with the "Target Extension" of the Cylinder added to Custom01:

KSP-TaxiService commented 5 years ago

Hi, thanks for showing the location of the axis group keybindings.

Flight Computer ignored the new axis groups as it did not know how to handle them. It now knows to use them.

KSP-TaxiService commented 5 years ago

I found another issue of a manual player extension input on a hydraulic being ignored.

ncanceill commented 5 years ago

Thanks for looking into this!

I am not sure I understand your last comment, please let me know if I can do something to help

KSP-TaxiService commented 5 years ago

You can replicate it by launching remote-controller vessel with 3 hinge, hydraulic and servo parts and change its target value. Only hinge and servo follows your target inputs.

I think this issue may be a stock bug and I am waiting for 1.7.3 to see if it is fixed. If not, I will roll out the pending fix.

ncanceill commented 5 years ago

OK I understand, thank you

I am far from my KSP install right now but I will try to confirm the bug next week

Anyway, from your description, I agree: it sounds like a Stock bug