RemoteTechnologiesGroup / RemoteTech

Community developed continuation of Kerbal Space Program's RemoteTech mod.
http://remotetechnologiesgroup.github.io/RemoteTech
GNU General Public License v2.0
230 stars 103 forks source link

Antennas auto extend and can't retract #798

Closed AndresHdzArv closed 4 years ago

AndresHdzArv commented 4 years ago

In editor antennas deploy themselves and can't retract them. They don't respond KSP. 1.8.1

KSP-TaxiService commented 4 years ago

Hi, Kindly assist to provide output_log.txt, screenshots of the self-deploy antennas and mod list, per guidelines.

I do not replicate this issue on clean KSP 1.8.1 install with RT develop build.

Thanks.

AndresHdzArv commented 4 years ago

Selfdeployvideo.zip

AndresHdzArv commented 4 years ago

That is the video with the issue

AndresHdzArv commented 4 years ago

KSP.log

KSP-TaxiService commented 4 years ago

Hi, The video zip you attached is empty. Please re-upload the video.

Is the issue happening on Communotron 16 and Communotron 88-88 only, or all the deployable antennas? I ask this question because there are few animation errors for both antennas according to your log.

[LOG 07:49:01.973] ModuleAnimateGeneric: Could not find animation component 'antenna' - on part longAntenna failed to load! Check the model file

I usually see such errors related to the model changes by Restock mod.

AndresHdzArv commented 4 years ago

Selfdeployvideo.zip

AndresHdzArv commented 4 years ago

The problem is with all antennas

BTAxis commented 4 years ago

Not really. As far as I can see, this issue applies to the Communotron 16, 88-88 and HG-55 only. All other antennas, be they stock or modded, seem to be unaffected.

AndresHdzArv commented 4 years ago

Those were the antennas I tested on it, so you may be right, even then, it’s still an important issue as they are the only antennas I have and if I can’t send them then I can’t advance my game

KSP-TaxiService commented 4 years ago

Hi AndresHdzArv,

Can you move ReStock mod out of your game installation and check if the issue persists? The errors I found are related to this mod.

BTAxis commented 4 years ago

I can confirm that removing ReStock does make this issue go away.

AndresHdzArv commented 4 years ago

Yes, without ReStock everything works properly, will this be fixed?

ChrisAdderley commented 4 years ago

I suspect this is an ordering issue. Order is currently

  1. RemoteTech patches antenna to transform ModuleDeployableAntenna into ModuleAnimateGeneric
  2. Restock changes the model
  3. Restock tries to patch antenna's ModuleDeployableAntenna's animation name and fails
  4. The RemoteTech-modfied ModuleAnimateGeneric is unhappy because the animation name does not exist.

Restock can ship a patch in the next version to target ModuleAnimateGeneric in the case that RemoteTech is installed.

ChrisAdderley commented 4 years ago

I've uploaded a potential fix for this here. It should resolve the issue.

KSP-TaxiService commented 4 years ago

Hi @ChrisAdderley,

Thanks so much for your assistance.

I confirm the following antennas having the animation problem.

I revise and incorporate your fix into the existing RemoteTech patch for ReStock.

Kindly assist to decommission your fix on ReStock's side.

ChrisAdderley commented 4 years ago

Done.