search

RemoteXY / RemoteXY-Arduino-library

RemoteXY library for Arduino IDE
http://remotexy.com
GNU Lesser General Public License v2.1
46 stars 18 forks source link

esp32 3.0.0-a breaks RemoteXY #23

Open ghost opened 7 months ago

ghost commented 7 months ago

Trying to compile a RemoteXY sketch for ESP32-H2 requires esp32 version 3.0.0-a.

Compilation fails with: c:\Users\tom\Documents\Arduino\libraries\RemoteXY\src/RemoteXYStream_BLEDevice.h: In member function 'virtual void CRemoteXYStream_BLEDevice::onWrite(BLECharacteristic*)':c:\Users\tom\Documents\Arduino\libraries\RemoteXY\src/RemoteXYStream_BLEDevice.h:110:52: error: conversion from 'String' to non scalar type 'std::string' {aka 'std::__cxx11::basic_string<char>'} requested 110 | std::string rxValue = pCharacteristic->getValue();

From espressif's migration guide from v2.* to v3.0.0:

Changed APIs return and parameter type from std::string to Arduino style String.

I assume this is related.

The same sketch compiles and functions with esp32 version 2.0.11

RemoteXY commented 7 months ago

Thanks. We have to plan the work to support ESP32 version 3. We will check all types of connections.