Open Kody-Quintana opened 1 year ago
RenaKunisaki
commented
1 year ago Strange. It does this immediately, before anything shows on the screen? The warnings are normal (something to tidy up eventually).
If you turn off "use panic handlers" in Dolphin's settings does it give a crash log?
Kody-Quintana
commented
1 year ago It does this right before the menu would normally show up, during the pink screen. Turning off panic handlers does not give a crash log. Also, pressing ok continues to give the same warning but the first value is incremented, spamming it continues to increment it
Kody-Quintana
commented
1 year ago If it helps at all, here are the versions of everything I'm using Dolphin:
Dolphin [makepkg] 5.0-17995-dirtyDevkit stuff:
dkp-linux/devkitPPC-gdb 7.6.2-1 (2.2 MiB 9.8 MiB) [gamecube-dev wii-dev wiiu-dev] (Installed)
gnu debugger for devkitPPC
dkp-linux/devkitPPC r41-2 (57.0 MiB 261.3 MiB) [gamecube-dev wii-dev wiiu-dev] (Installed)
Toolchain for Nintendo Gamecube & Wii homebrew development
dkp-libs/devkitppc-rules 1.1.1-1 (4.1 KiB 22.0 KiB) [gamecube-dev wii-dev wiiu-dev] (Installed)
devkitPPC build rules.
dkp-libs/devkitppc-cmake 1.1.2-1 (2.5 KiB 294.0 B) [gamecube-dev wii-dev wiiu-dev] (Installed)This seems to be an issue loading a file from disc, but I can't tell which. If you put this file at ~/.local/share/dolphin-emu/Maps/GSAE01.map and enable Dolphin's debug UI, you should be able to see the game's log, that will most likely help.
Kody-Quintana
commented
1 year ago This is what I got:
RenaKunisaki
commented
1 year ago Oof, looks like Dolphin might have changed how it interprets logs again. The problem happens when loading the sky textures, but I don't know what would cause that. I'll keep looking into it.
Kody-Quintana
commented
1 year ago Thanks for looking into this, very appreciated.
Could this be related to the ../browser/data/U0/gamebits.xml file? I'm not 100% sure what file that should be. I see two repos here that have a file like that:
I've tried using both but I don't really know what I'm doing.
Attempting to build the iso without either of those two results in:
[*] Done.
[*] Installing...
[*] Entry point: 0x0000E4C4
[*] GOT Offs=0x000000F4, Size=0x0000114E, bootstrap=0x000000F0
Traceback (most recent call last):
File "/home/user/SFA-Amethyst/./tools/makebitnames.py", line 11, in <module>
gameBits = ET.parse(sys.argv[1]).getroot()
File "/usr/lib/python3.10/xml/etree/ElementTree.py", line 1222, in parse
tree.parse(source, parser)
File "/usr/lib/python3.10/xml/etree/ElementTree.py", line 569, in parse
source = open(source, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '../browser/data/U0/gamebits.xml'
make: *** [Makefile:60: install] Error 1That file is a list of game flag names for the debug menu. It shouldn't matter during startup. The one in SFA-Browser is the correct one. That's something I need to clean up eventually.
Applying the pre-built patch works fine. When I attempt to build from this repo I get:
when running in dolphin
Output of make iso
``` #./tools/genSymbols.py include/sfa/ build/ [*] Generate symbols.s make[1]: Entering directory '/home/user/SFA-Amethyst' [*] Assembling: dolpatch/dolpatch.s make[1]: Entering directory '/home/user/SFA-Amethyst' [*] Linking... [*] Extracting: /home/user/SFA-Amethyst/build/dolpatch.bin /home/user/SFA-Amethyst/src/drawtext.c: In function '_drawCharColored': /home/user/SFA-Amethyst/src/drawtext.c:136:21: warning: passing argument 1 of 'gxSetProjection' from incompatible pointer type [-Wincompatible-pointer-types] 136 | gxSetProjection(&hudMatrix, TRUE); | ^~~~~~~~~~ | | | f32 (*)[4][4] {aka float (*)[4][4]} In file included from include/sfa/sfa.h:11, from /home/user/SFA-Amethyst/src/main.h:1, from /home/user/SFA-Amethyst/src/drawtext.c:1: include/sfa/funcs.h:101:37: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 101 | GLOBALFN void gxSetProjection(Mtx * mtx, BOOL ortho); | ~~~~~~^~~ [*] Applying DOL patch... /home/user/SFA-Amethyst/src/drawarrow.c: In function 'drawArrow': /home/user/SFA-Amethyst/src/drawarrow.c:20:18: warning: passing argument 1 of 'PSMTXIdentiy' from incompatible pointer type [-Wincompatible-pointer-types] 20 | PSMTXIdentiy(&m); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} In file included from include/sfa/sfa.h:11, from /home/user/SFA-Amethyst/src/main.h:1, from /home/user/SFA-Amethyst/src/drawarrow.c:1: include/sfa/funcs.h:217:33: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 217 | GLOBALFN void PSMTXIdentiy(Mtx *M); | ~~~~~^ /home/user/SFA-Amethyst/src/drawarrow.c:21:22: warning: passing argument 1 of 'mtxRotateByVec3s' from incompatible pointer type [-Wincompatible-pointer-types] 21 | mtxRotateByVec3s(&m, &rot); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:169:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 169 | GLOBALFN void mtxRotateByVec3s(Mtx * mtx, vec3s * rot); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/drawarrow.c:22:22: warning: passing argument 1 of 'vec3f_multByMtx2' from incompatible pointer type [-Wincompatible-pointer-types] 22 | vec3f_multByMtx2(&m, &a, &a); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:271:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 271 | GLOBALFN void vec3f_multByMtx2(Mtx * mtx, vec3f * vIn, vec3f * vOut); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/drawarrow.c:23:22: warning: passing argument 1 of 'vec3f_multByMtx2' from incompatible pointer type [-Wincompatible-pointer-types] 23 | vec3f_multByMtx2(&m, &b, &b); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:271:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 271 | GLOBALFN void vec3f_multByMtx2(Mtx * mtx, vec3f * vIn, vec3f * vOut); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/drawarrow.c:24:22: warning: passing argument 1 of 'vec3f_multByMtx2' from incompatible pointer type [-Wincompatible-pointer-types] 24 | vec3f_multByMtx2(&m, &c, &c); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:271:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 271 | GLOBALFN void vec3f_multByMtx2(Mtx * mtx, vec3f * vIn, vec3f * vOut); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/drawarrow.c:25:22: warning: passing argument 1 of 'vec3f_multByMtx2' from incompatible pointer type [-Wincompatible-pointer-types] 25 | vec3f_multByMtx2(&m, &d, &d); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:271:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 271 | GLOBALFN void vec3f_multByMtx2(Mtx * mtx, vec3f * vIn, vec3f * vOut); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/drawarrow.c:26:22: warning: passing argument 1 of 'vec3f_multByMtx2' from incompatible pointer type [-Wincompatible-pointer-types] 26 | vec3f_multByMtx2(&m, &e, &e); | ^~ | | | f32 (*)[4][4] {aka float (*)[4][4]} include/sfa/funcs.h:271:38: note: expected 'f32 (*)[3][4]' {aka 'float (*)[3][4]'} but argument is of type 'f32 (*)[4][4]' {aka 'float (*)[4][4]'} 271 | GLOBALFN void vec3f_multByMtx2(Mtx * mtx, vec3f * vIn, vec3f * vOut); | ~~~~~~^~~ /home/user/SFA-Amethyst/src/krystal.c: In function 'krystal_loadAssets': /home/user/SFA-Amethyst/src/krystal.c:29:48: warning: passing argument 2 of 'loadFileByPath' from incompatible pointer type [-Wincompatible-pointer-types] 29 | krystalModel = loadFileByPath(pathMod, &krystalModelSize); | ^~~~~~~~~~~~~~~~~ | | | u32 * {aka long unsigned int *} In file included from include/sfa/sfa.h:11, from /home/user/SFA-Amethyst/src/main.h:1, from /home/user/SFA-Amethyst/src/krystal.c:3: include/sfa/funcs.h:138:48: note: expected 'uint *' {aka 'unsigned int *'} but argument is of type 'u32 *' {aka 'long unsigned int *'} 138 | GLOBALFN void* loadFileByPath(char *path,uint *outSize); | ~~~~~~^~~~~~~ /home/user/SFA-Amethyst/src/krystal.c:41:50: warning: passing argument 2 of 'loadFileByPath' from incompatible pointer type [-Wincompatible-pointer-types] 41 | krystalTexture = loadFileByPath(pathTex, &krystalTextureSize); | ^~~~~~~~~~~~~~~~~~~ | | | u32 * {aka long unsigned int *} include/sfa/funcs.h:138:48: note: expected 'uint *' {aka 'unsigned int *'} but argument is of type 'u32 *' {aka 'long unsigned int *'} 138 | GLOBALFN void* loadFileByPath(char *path,uint *outSize); | ~~~~~~^~~~~~~ /opt/devkitpro/devkitPPC/bin/../lib/gcc/powerpc-eabi/12.1.0/../../../../powerpc-eabi/bin/ld: warning: cannot find entry symbol _start; defaulting to 0000000000000000 done make[1]: Leaving directory '/home/user/SFA-Amethyst' /home/user/SFA-Amethyst/src/debugprint.c: In function 'printEnvironment': /home/user/SFA-Amethyst/src/debugprint.c:556:50: warning: iteration 5 invokes undefined behavior [-Waggressive-loop-optimizations] 556 | debugPrintf("%04X ", env->envFxActIdx[i] & 0xFFFF); | ~~~~~~~~~~~~~~~~^~~ /home/user/SFA-Amethyst/src/debugprint.c:553:23: note: within this loop 553 | for(int i=0; i<8; i++) { | ~^~ #@rm /home/user/SFA-Amethyst/build/bootstrap.elf /home/user/SFA-Amethyst/src/menuDebugGameBits.c: In function 'getBitName': /home/user/SFA-Amethyst/src/menuDebugGameBits.c:114:18: warning: passing argument 1 of 'free' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 114 | free(bitNames); | ^~~~~~~~ In file included from include/sfa/sfa.h:11, from /home/user/SFA-Amethyst/src/main.h:1, from /home/user/SFA-Amethyst/src/menuDebugGameBits.c:3: include/sfa/funcs.h:49:20: note: expected 'void *' but argument is of type 'const char *' 49 | GLOBALFN void free(void*); | ^~~~~ Input: /home/user/SFA-Amethyst/build/dolpatch.bin Output: /home/user/SFA-Amethyst/build/main.patched.dol Patch size: 0xBD Section Offset MemAddr Size EndOfs EndAddr text0 000100 80003100 002520 002620 80005620 text1 002620 800066E0 2BB1A0 2BD7C0 802C1880 text2 000000 00000000 000000 000000 00000000 text3 000000 00000000 000000 000000 00000000 text4 000000 00000000 000000 000000 00000000 text5 000000 00000000 000000 000000 00000000 text6 000000 00000000 000000 000000 00000000 data00 2BD7C0 80005620 0006A0 2BDE60 80005CC0 data01 2BDE60 80005CC0 000A20 2BE880 800066E0 data02 2BE880 802C1880 000020 2BE8A0 802C18A0 data03 2BE8A0 802C18A0 000020 2BE8C0 802C18C0 data04 2BE8C0 802C18C0 0014A0 2BFD60 802C2D60 data05 2BFD60 802C2D60 072AE0 332840 80335840 data06 332840 803DB1E0 0015C0 333E00 803DC7A0 data07 333E00 803DE500 009F40 33DD40 803E8440 data08 000000 00000000 000000 000000 00000000 data09 000000 00000000 000000 000000 00000000 data10 000000 00000000 000000 000000 00000000 BSS ------ 80335840 0B2C38 ------ 803E8478 Entry ------ 80003140 ------ ------ -------- jumpAddr=0x80020E98 loadAddr=0x80003E6C Jump is at offset 0x01CDD8, section .text1 Load offset 0x000E6C (section .text0) Patch opcode = 0x4BFE2FD5, offset = 0xFFFE2FD4 Patch OK /home/user/SFA-Amethyst/src/menuDebugObjs.c: In function 'objMenuShow': /home/user/SFA-Amethyst/src/menuDebugObjs.c:271:9: warning: converting a packed 'ObjDef_Override' pointer (alignment 1) to a 'ObjDef' pointer (alignment 4) may result in an unaligned pointer value [-Waddress-of-packed-member] 271 | 5, -1, -1, NULL); | ^ In file included from include/sfa/types.h:55, from include/sfa/sfa.h:9, from /home/user/SFA-Amethyst/src/main.h:1, from /home/user/SFA-Amethyst/src/menuDebugObjs.c:3: include/sfa/objects/objdef.h:1504:23: note: defined here 1504 | typedef struct PACKED ObjDef_Override { | ^~~~~~~~~~~~~~~ include/sfa/objects/objdef.h:1491:16: note: defined here 1491 | typedef struct ObjDef { | ^~~~~~ /home/user/SFA-Amethyst/src/title.c: In function 'titleHooksInit': /home/user/SFA-Amethyst/src/title.c:122:18: warning: assignment to 'int (*)()' from 'u32' {aka 'long unsigned int'} makes pointer from integer without a cast [-Wint-conversion] 122 | oldTitleHook = *(u32*)0x8031a320; | ^ [*] Linking... done make[1]: Leaving directory '/home/user/SFA-Amethyst' [*] Done. [*] Installing... [*] Entry point: 0x0000E4C4 [*] GOT Offs=0x000000F4, Size=0x0000114E, bootstrap=0x000000F0 WARNING: Duplicate GameBit name: 'ITEM_DIMSilverKey_Used' [*] Preparing files... [*] Building ISO... ./tools/isobuilder/__main__.py overwrite setName "Star Fox Adventures: Amethyst Edition" patchIso original.iso patched.iso ./patchfiles Read boot.bin from 0x00000000 Read bi2.bin from 0x00000440 Read appldr from 0x00002440 Read fst.bin from 0x0035BE00 Read main.dol from 0x0001E000 Read files from 0x0035BD40 Have dir: /gamefront Replace: /gamefront/TEX0.tab Add file: /kt0 Add file: /km1 Add file: /km0 Add file: /bitnames.dat Add file: /kt1 Replace: /opening.bnr Add file: /boot.bin Replace: /globalma.bin Building FST... Write boot.bin at 0x00000000 Write bi2.bin at 0x00000440 Write appldr at 0x00002440 Write main.dol at 0x0001E000 Write fst.bin at 0x0035BE00 Write files at 0x00378000 Write 0/ 3416 at 0x00378000 size 0x000325A0: /AMAP.BIN ... redacted to stay under GitHub max comment length Write 3415/ 3416 at 0x33F30000 size 0x00001900: /worldmap/VOXMAP.tab Updating FST... Updating boot.bin... ```Is the repo currently in a buildable state? Or is there a known good commit to use? For context my goal is to see if 21:9 ultrawide is possible by doing something like:
but I can't get it to run even without the above changes