search

Renanse / Ardor3D

Ardor3D is a free Java based, professionally oriented, open source 3D graphics engine.
Other
227 stars 77 forks source link

Fix typos in Javadoc comments. #67

Closed green-coder closed 10 years ago

green-coder commented 10 years ago

PS: please try to merge this commit using a fast-forward commit instead of an explicit merge commit.

buildhive commented 10 years ago

Joshua Slack » Ardor3D #129 SUCCESS This pull request looks good (what's this?)

buildhive commented 10 years ago

Joshua Slack » Ardor3D #130 SUCCESS This pull request looks good (what's this?)

Renanse commented 10 years ago

I am fine with github's merge default. There's no compelling reason I know of that we have to skip the merge. Do you know of one aside from aesthetic sensibility? :)

green-coder commented 10 years ago

"Aesthetic sensibility" is also called readability, depending the context, design or programming. I wouldn't mind that much if you prefer to have an additional merge commit. (no, I don't have an OCD :-) )

Renanse commented 10 years ago

It's not so much a matter of preference as it is "using the tools" github gives. I understand what you mean though.

green-coder commented 10 years ago

FYI, an article from someone else who also doesn't like the extra merge commit: http://adammonsen.com/post/1172

Renanse commented 10 years ago

Yeah, but then he writes:

Update 2013-06-25 I now prefer what GitHub’s merge button does, namely: preserving the merge history for pull requests.