Renaud11232 / OctoPrint-Marlin-Flasher

Arduino/Marlin firmware flasher for OctoPrint
MIT License
38 stars 10 forks source link

[BUG] Default file upload limit renders plugin unusable #87

Closed orrinwitt closed 1 year ago

orrinwitt commented 2 years ago

Unless I'm misunderstanding something...

I'm very confused, because the full project when zipped with the current Marlin firmware (2.1.1) is around 83mb. With an upload size limit of 20mb, that makes it impossible to upload the project.

3 questions:

  1. Are there files I should be excluding from the zip?
  2. Do I need to edit the configuration file from 20mb to something big enough?
  3. Is there a reason for the 20mb limit that will cause problems if I more than quadruple the limit size?
orrinwitt commented 2 years ago

ok, so based on the image in this closed issue, it would seem i need to exclude the folders: .pio and .vscode this renders a .zip file under 10mb

is that correct?

Renaud11232 commented 2 years ago

Hello,

Yes, the zip file should not contain these files. .vscode is specific to Visual Studio code and won't be used .pio contains various files including the compiled firmware (if you compiled it already) which will be ignored since Platform IO will recompile the project anyway.

orrinwitt commented 2 years ago

Thank you for the help! I ended up running into another issue, which I reference here:

https://github.com/MarlinFirmware/AutoBuildMarlin/issues/61

It seems to me that it's a platformio issue, but it affected your plugin as well. not sure if it's specific to my board or what, but I was surprised to see it affected me across 3 computers and 2 operating systems.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. If this is related to a bug you experienced, make sure you provided all requested information. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically closed due to inactivity.