search

RenaudRohlinger / stats-gl

https://stats.renaudrohlinger.com/
181 stars 7 forks source link

Expand range of @types/three #9

Closed Methuselah96 closed 3 months ago

Methuselah96 commented 6 months ago

Currently the @types/three is locked into @types/three@0.163.0, but it would be nice to allow different major versions of @types/three so that a user can match the version of @types/three with the version their app is using. For example, I just upgraded my app to @types/three@0.164.0, but @types/three@0.163.0 is still installed because of this dependency. With this change, I would be able to make them all resolve to @types/three@0.164.0. This would allow more flexibility for users to use whatever version of @types/three they're using in their app.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stats-gl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 4:29pm
s-rigaud commented 2 months ago

@RenaudRohlinger Would it be possible to get a release (maybe 2.2.9) of the package to include this change ?

Your project is used by @react-three/drei and installing the current version 9.111.3 also requires three version 0.167.0. Installing drei still leads to having types for both version of three.js (@167 and @163) and many TS warnings for incompatible types.

GuskiS commented 1 week ago

Yes, can this be released?

RenaudRohlinger commented 10 hours ago

Sorry for the delay. It's been released in 2.3.1