search

Render96 / Render96ex

Fork of https://github.com/sm64-port/sm64-port with additional features.
228 stars 42 forks source link

Fix linking issues on parallel builds #84

Open flatmapthatshit opened 11 months ago

flatmapthatshit commented 11 months ago

While the Wiki often encourages parallel builds (e.g., with make -j4), tools/Makefile is not currently safe for parallel builds as it doesn't currently account for dependencies between programs.

E.g.:

More often than not, trying to compile tools with make -j4 will fail due to tabledesign finishing to compile before audiofile and then failing to link.

While this would ideally be solved by introducing separate rules per program accounting for dependencies, for now I'm forcing j1 for tools.

This fix was already merged upstream as part of PR https://github.com/sm64pc/sm64ex/pull/512

flatmapthatshit commented 11 months ago

@AndratVA has already backported this fix to branch tester_rt64alpha (https://github.com/Render96/Render96ex/commit/97fc00e0bbb93657b9ac50657a3d9989b4c9f019)