search

RenderHeads / UnityPlugin-AVProVideo

AVPro Video is a multi-platform Unity plugin for advanced video playback
https://www.renderheads.com/products/avpro-video/
239 stars 29 forks source link

MediaPlayer.OpenVideoFromFile freezes when misspelled/missing folder on path #297

Closed XavierWielemans closed 4 years ago

XavierWielemans commented 4 years ago

Hello, Recently I rearranged the folders structure of StreamingAssets in my project. I forgot to reflect the change in the code loading the video files (using MediaPlayer.OpenVideoFromFile) and at the next run the unity editor just freezes to death when calling the OpenVideoFromFile method. No log, no warning, no error - just a plain freeze. Had to kill the editor and restart. I was able to reproduce this several times, with different projects and different folders name errors within StreamingAssets. Fixing the differences between the actual folder names and the path given as argument to OpenVideoFromFile solves the issue...

Your Setup (please complete the following information):

To Reproduce

  1. inside a script, open a video using MediaPlayer.OpenVideoFromFile(MediaPlayer.FileLocation.RelativeToStreamingAssetsFolder, stringContainingMisspelledOrMissingFolderInPath, autoPlay: true);
  2. run in editor
  3. watch it freeze beautifully when trying to load

Logs n/a

Screenshots n/a

Videos n/a

Please DO NOT LINK / ATTACH YOUR PROJECT FILES HERE

If you need a reproducible project, let me know. Cheers guys!

Xavier

AndrewRH commented 4 years ago

Thanks @XavierWielemans Do you know whether you had the Build Platform set to Android? We have a check in there for file not found, but it seems there was a mistake and if the Built Platform is set to Android then it will not do that check... So I suspect that might be the problem, but if you could let me know then we can confirm that.

Thanks,

XavierWielemans commented 4 years ago

Hi Andrew, Sorry, no, build platform is windows/x86.I have been building Android apps recently, but not for that particular project where I experienced the freezes... Sorry! :/

Le mar. 24 mars 2020 à 19:25, Andrew notifications@github.com a écrit :

Thanks @XavierWielemans https://github.com/XavierWielemans Do you know whether you had the Build Platform set to Android? We have a check in there for file not found, but it seems there was a mistake and if the Built Platform is set to Android then it will not do that check... So I suspect that might be the problem, but if you could let me know then we can confirm that.

Thanks,

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/297#issuecomment-603428858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6ENIQARCO4TZXRV56MRP3RJD3JFANCNFSM4LQIJYBA .

-- http://tinybigstory.be/ tinybigstory sprl

Avenue de la Paix 44 B-1420 Braine-l'Alleud Belgique +32 472 98 56 97 xavier@tinybigstory.be skype: xavier.wielemans

TVA BE 0501.800.004 IBAN BE29 3631 1365 7364 BIC BBRUBEBB (ING Belgium)

http://www.tinybigstory.be

AndrewRH commented 4 years ago

Hmm that's really strange then...I can't imagine why there would be a crash. I certainly can't replicate the crash here if I put in an incorrect path. The C# code checks whether the file exists and if it doesn't it won't even ask the plugin to load it.....hmmm

XavierWielemans commented 4 years ago

Weird. If I come across this again in another project, I'll let you know. Must be some super-rare combination of factors... Usually I just get a "file not found" message indeed. This time the only specific aspect was that I had changed the path to the files (moved all my videos in a subfolder and forgot to adjust the path in my unity script)... Don't know if it helps you.

Le mer. 25 mars 2020 à 16:48, Andrew notifications@github.com a écrit :

Hmm that's really strange then...I can't imagine why there would be a crash. I certainly can't replicate the crash here if I put in an incorrect path. The C# code checks whether the file exists and if it doesn't it won't even ask the plugin to load it.....hmmm

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/297#issuecomment-603917588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6ENIW6NMKCYJMKA73KBG3RJIRT3ANCNFSM4LQIJYBA .

-- http://tinybigstory.be/ tinybigstory sprl

Avenue de la Paix 44 B-1420 Braine-l'Alleud Belgique +32 472 98 56 97 xavier@tinybigstory.be skype: xavier.wielemans

TVA BE 0501.800.004 IBAN BE29 3631 1365 7364 BIC BBRUBEBB (ING Belgium)

http://www.tinybigstory.be

XavierWielemans commented 4 years ago

Maybe that caused some .meta files along the path to be temporarily erroneous, and that caused the crash?

Le mer. 25 mars 2020 à 16:54, Xavier Wielemans xavier@tinybigstory.be a écrit :

Weird. If I come across this again in another project, I'll let you know. Must be some super-rare combination of factors... Usually I just get a "file not found" message indeed. This time the only specific aspect was that I had changed the path to the files (moved all my videos in a subfolder and forgot to adjust the path in my unity script)... Don't know if it helps you.

Le mer. 25 mars 2020 à 16:48, Andrew notifications@github.com a écrit :

Hmm that's really strange then...I can't imagine why there would be a crash. I certainly can't replicate the crash here if I put in an incorrect path. The C# code checks whether the file exists and if it doesn't it won't even ask the plugin to load it.....hmmm

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/297#issuecomment-603917588, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6ENIW6NMKCYJMKA73KBG3RJIRT3ANCNFSM4LQIJYBA .

-- http://tinybigstory.be/ tinybigstory sprl

Avenue de la Paix 44 B-1420 Braine-l'Alleud Belgique +32 472 98 56 97 xavier@tinybigstory.be skype: xavier.wielemans

TVA BE 0501.800.004 IBAN BE29 3631 1365 7364 BIC BBRUBEBB (ING Belgium)

http://www.tinybigstory.be

-- http://tinybigstory.be/ tinybigstory sprl

Avenue de la Paix 44 B-1420 Braine-l'Alleud Belgique +32 472 98 56 97 xavier@tinybigstory.be skype: xavier.wielemans

TVA BE 0501.800.004 IBAN BE29 3631 1365 7364 BIC BBRUBEBB (ING Belgium)

http://www.tinybigstory.be

AndrewRH commented 4 years ago

I'm closing this as I cannot replicate and seems to be a super edge case that nobody else has reported.

Thanks,