RenderHeads / UnityPlugin-AVProVideo

AVPro Video is a multi-platform Unity plugin for advanced video playback
https://www.renderheads.com/products/avpro-video/
231 stars 28 forks source link

Vulkan support #809

Closed wyb314 closed 6 months ago

wyb314 commented 3 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

kahnivore commented 3 years ago

Hi @wyb314

It's on our roadmap but we unfortunately cannot provide a timeframe for this currently.

Thanks.

ys4kw commented 3 years ago

I'm waiting too. A lot of Android support vulkan and performance is better than other graphic api.

I have replaced to v2 from v1 for this thing.

Which problem makes it difficult to implement? Can we use the api in near future?

kahnivore commented 3 years ago

Hi @ys4kw

We're a small team and therefore need to prioritise the features that have the most requests. We haven't had that many requests for Vulkan and are not sure it's going to make much of a difference to performance. It's still on the roadmap but is unlikely to be implemented in the near future.

whitecostume commented 3 years ago

If don't support Vulkan, it will affect our project to use Vulkan

740919820 commented 2 years ago

我们项目同样使用了Vulkan来增强渲染,但是就不能使用AVProVideo,目前正在寻找替代方案。如果能尽快支持Vulkan就更好了

PitLos commented 2 years ago

One more request for Vulkan

jstarrdewar commented 2 years ago

+1 for Vulkan. We are ready to move to Vulkan now for the gameplay portion of our application. Obviously we don't expect to see much benefit in the video playback portion of the experience, but we are anticipating very big improvements in the rest of the application, and unfortunately switching is an all-or-nothing proposition as far as I know.

gindemit commented 2 years ago

+1 for Vulkan. As mentioned previously, Vulkan affects the overall performance of the app. We can't use this plugin until the support is there.

gindemit commented 2 years ago

Hi @ys4kw

We're a small team and therefore need to prioritise the features that have the most requests. We haven't had that many requests for Vulkan and are not sure it's going to make much of a difference to performance. It's still on the roadmap but is unlikely to be implemented in the near future.

Can I maybe help with implementing the Vulkan support? If you are interested in any help, please drop me an email: k.hindemith@gmail.com

gtk2k-2 commented 2 years ago

Please support Vulkan. As others have said, I'd like to switch to Vulkan to improve overall game performance, but since AVProVideo doesn't support it, I'm currently building with Vulkan with the video player feature removed.

LostSenseT-T commented 2 years ago

One more for Vulkan. It is not possible to use VFXGraph with AVpro on Android (Oculus Quest 2) as VFXGraph requires Vulkan.

DCowling commented 2 years ago

+1 for Vulkan, AVPro support here is what gates our transition to this API for Quest titles currently using OpenGL ES.

AvinashChanga commented 2 years ago

+1 for Vulkan, echoing the above. AVPro is very useful for Quest, and since Oculus has now officially supported Vulkan for about 2 years, AVPro is now a plugin holding that holds certain projects back, requiring us to look for other solutions. (While the preference would be to keep using AVPro.)

MrT3D commented 2 years ago

+1 for Vulkan. Most projects on Quest will be Vulkan. If there is not Vulkan support, we will have to choose between AVProVideo or VFX Graph. AVProVideo will likely lose that battle.

gindemit commented 2 years ago

In our project we use currently Unity Video Player. For playing videos from Firebase Storage Https Urls it works pretty good. It supports Vulkan API. But if you decide to use it, implement it with a wrapper class, to have some space to implement small tweaks to the video playback if you experience bugs or missing functionality.

Feynmen commented 2 years ago
WikkidEdd commented 2 years ago

+1 For vulkan

Chris-RH commented 2 years ago

Thank you for your interest. It is very helpful to see which future enhancements are most popular. Vulkan support is in the roadmap for the future, but no dates as of yet.

On Fri, 19 Aug 2022, 13:10 Edd Smith, @.***> wrote:

+1 For vulkan

— Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/809#issuecomment-1220600911, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUPFQPTBPQUCBZY3OTDVZ52TRANCNFSM4572PB4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

wonkee-kim commented 1 year ago

+1 for Vulkan. Will there be any chance to priotize this? It's 2022 and Vulkan is necessary for performance.

Chris-RH commented 1 year ago

Thank you @wonkee-kim. It is on the to-do list :)

spotd commented 1 year ago

+1 for Vulkan. Hit a brick wall on exhibit install when it turns out blending (backstage / brainsalt) requires Vulkan to work. I now have to strip out the video player in all code. Its an expensive product and should support this level of install

Chris-RH commented 1 year ago

Thank you for your interest @spotd. It is an enhancement that is popular, so we are looking forward to adding it in the future.

dan-geniusx commented 1 year ago

+1 major Quest 2 optimizations like Asynchronous Space Warp 2.0 only support Vulkan.

ngz82 commented 1 year ago

+1 for Vulkan support. It would be great to get a bit more clarity on when this might become available.

TORISOUP commented 1 year ago

+1

MrT3D commented 1 year ago

+1 Vulkan. We require Vulkan + video for Quest dev (as do most devs targeting the Quest).

WikkidEdd commented 1 year ago

Happy New Year!

Is there any update on the roadmap for this?

As someone else already mentioned, the desire for this isn't about gains in AVPro Video's performance it's about the rest of the app. For us compatibility is the more important factor, we have other features we need that only support Vulkan and we're blocked from rolling out those features until we can find a solution for video playback on Vulkan. It's not a good situation to be in.

If you could give us any kind of estimate (3, 6 or 12 months?) It would help us lot in planning our way forward, we don't want to spend time working out another solution only to find you release Vulkan support in 3 months time for example.

AV Pro plugins have been our go-to for many years. They are by far the most robust and performant plugins on the asset store. Even supporting ARM64 UWP for HoloLens 2 which is super niche, it's surprising that Vulkan for Android/Quest 2 hasn't received the same love.

Chris-RH commented 1 year ago

We recently added Vulkan support to our other asset AVPro Movie Capture at the end of November last year, so we have a bit of any of what we are getting into.
We hope to start putting some code together to enable Vulkan support for AVPro Video soon and then a cycle of in-house testing and tweaking will start.
This is a major update that we are all very keen to get out. However, at this stage of development, we don't like to throw dates out and potentially have to disappoint people if the product is not sufficiently ready for release.

DmitrySwearl commented 1 year ago

+1 Vulkan. We will be waiting ur updates soon. Is it possible to let us know when you have an understanding of the approximate release date (month)

Chris-RH commented 1 year ago

As mentioned previously, I can't give out an exact month I'm afraid. Its unlikely to happen in the next few months as the team are working on some external projects.

HannaGurwitzTT commented 1 year ago

+1 Vulkan A different plugin in our application requires vulkan support, thus making it incompatible with AVPro. Is there any update on this? Thank you!

jg33 commented 1 year ago

+1 from me as well! It would be essential for a project we're working on.

Thanks- great work!

MrT3D commented 1 year ago

Any news?

Chris-RH commented 1 year ago

It is being worked on.

whitecostume commented 1 year ago

come on

syshex commented 1 year ago

Any update on this?

Chris-RH commented 1 year ago

We are working on it :)

On Thu, 13 Jul 2023 at 20:44, Rui Pereira @.***> wrote:

Any update on this?

— Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/809#issuecomment-1634811903, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUOA7XN7XV54BEBLIILXQBF3HANCNFSM4572PB4A . You are receiving this because you commented.Message ID: @.***>

syshex commented 1 year ago

I get it, I read the thread. But is it a "this year" or in a couple of years kind of deal? I understand not wanting to state a date, but no idea of timeframe makes it impossible for others to make decisions.

We are working on it :) On Thu, 13 Jul 2023 at 20:44, Rui Pereira @.> wrote: Any update on this? — Reply to this email directly, view it on GitHub <#809 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUOA7XN7XV54BEBLIILXQBF3HANCNFSM4572PB4A . You are receiving this because you commented.Message ID: @.>

Chris-RH commented 1 year ago

We are aiming for Q4 this year

On Thu, 13 Jul 2023 at 21:44, Rui Pereira @.***> wrote:

I get it, I read the thread. But is it a "this year" or in a couple of years kind of deal? I understand not wanting to state a date, but no idea of timeframe makes it impossible for others to make decisions.

We are working on it :) … <#m-1808604686471055383> On Thu, 13 Jul 2023 at 20:44, Rui Pereira @.> wrote: Any update on this? — Reply to this email directly, view it on GitHub <#809 (comment) https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/809#issuecomment-1634811903>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUOA7XN7XV54BEBLIILXQBF3HANCNFSM4572PB4A https://github.com/notifications/unsubscribe-auth/AYRROUOA7XN7XV54BEBLIILXQBF3HANCNFSM4572PB4A . You are receiving this because you commented.Message ID: @.>

— Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/809#issuecomment-1634890550, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUJTJYI3PDB6MNK6MQTXQBM2JANCNFSM4572PB4A . You are receiving this because you commented.Message ID: @.***>

Ste-RH commented 1 year ago

As we have been quite quiet regarding Vulkan support, I can today announce that Android Vulkan support will 100% be arriving with AVPro Video version 3.0. We very much hope to release this major version before the end of the year.

whitecostume commented 1 year ago

amazing! thank you

MrT3D commented 11 months ago

Thanks!

firdiar-mita commented 10 months ago

im waiting :)

syshex commented 9 months ago

As we have been quite quiet regarding Vulkan support, I can today announce that Android Vulkan support will 100% be arriving with AVPro Video version 3.0. We very much hope to release this major version before the end of the year.

@Ste-RH @Chris-RH

How is this going? Are we still on track for Q4? Can we have a date?

nofkobw commented 7 months ago

How long will it take to work on vulkan support?

Chris-RH commented 7 months ago

Hi,

We're a very small team and it will be out when it is ready.

On Thu, 11 Jan 2024 at 07:47, Nicole Serrano @.***> wrote:

How long will it take to work on vulkan support?

— Reply to this email directly, view it on GitHub https://github.com/RenderHeads/UnityPlugin-AVProVideo/issues/809#issuecomment-1886524790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYRROUNUDM4UCUNF2E6RUOLYN6KIXAVCNFSM4572PB4KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBYGY2TENBXHEYA . You are receiving this because you were mentioned.Message ID: @.***>

BadZhang commented 7 months ago

im waiting :)

mandelbox commented 7 months ago

Also very interested in this.

DmitrySwearl commented 7 months ago

Waiting as well :)

cieraej commented 6 months ago

hi! Any updates when Vulkan will be supported with Av Pro? Thanks :)