search

RenderKit / embree

Embree ray tracing kernels repository.
Apache License 2.0
2.37k stars 389 forks source link

Replace relative includes by absolute ones #393

Closed Vertexwahn closed 2 years ago

Vertexwahn commented 2 years ago

The goal here is to make all include paths relative to the Embree root directory. For instance, in the file "kernels/builders/heuristic_binning.h"

include "../../common/algorithms/parallel_partition.h" (current variant)

is simply the same as "common/algorithms/parallel_partition.h". The latter include makes it clear where I can find the file while the first variant, forces me to think where the parent of the parent folder is located relative to the file where I am in. I would propose to change all includes to "relative to Embree root dir".

svenwoop commented 2 years ago

Could you please explain what issue this fixed?

Vertexwahn commented 2 years ago

@svenwoop I added an explanation of why I want to do this. If you do not like it free to close the PR.

svenwoop commented 2 years ago

I understand why you are doing it but want to keep this as is. We once probably want to separate the library into more components anyway and then need to change this anyway.