Remove searching for TBB in embree-config.cmake

RenderKit / embree

Embree ray tracing kernels repository.

Apache License 2.0

2.32k stars 383 forks source link

Remove searching for TBB in embree-config.cmake #407

Closed stephanlachnit closed 1 year ago

stephanlachnit commented 1 year ago

Having FIND_PACKAGE(TBB) in embree-config.cmake adds an unnecessary constraint - namely that users now needs TBB development files on their system to use Embree. In environments with shared libraries like e.g. classic linux distributions, a user might have the TBB shared libraries for Embree installed but not the developments files. Any component checks should only happen during build time of Embree.

Closes https://github.com/embree/embree/issues/401

/cc @sherholz-intel @svenwoop

Neumann-A commented 1 year ago

This breaks if the embree targets depend on tbb targets which will happen if embree is build statically with tbb. (also the config should use find_dependency instead of find_package())

freibold commented 1 year ago

We have moved the find_package inside a IF(EMBREE_STATIC) conditional and replaced it with find_dependency. https://github.com/embree/embree/commit/d411a39530da93fe68a5a41b84f335cacefb693f Please let us know if the problem still persists. Thanks for the PR!