search

RenderKit / embree

Embree ray tracing kernels repository.
Apache License 2.0
2.37k stars 389 forks source link

Move CMAKE_MINIMUM_REQUIRED to the top #421

Closed Neumann-A closed 1 year ago

Neumann-A commented 1 year ago

From https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

Call the cmake_minimum_required() command at the beginning of the top-level CMakeLists.txt file even before calling the project() command. It is important to establish version and policy settings before invoking other commands whose behavior they may affect. See also policy CMP0000.

freibold commented 1 year ago

Thanks for this PR! We've already had exactly the same PR in October last year https://github.com/embree/embree/pull/406 We've already merged that into our internal development branch and it will be updated here soon. Sorry for the long wait!