search

RenderKit / embree

Embree ray tracing kernels repository.
Apache License 2.0
2.32k stars 383 forks source link

Fix @rpath reference for macOS #455

Closed carlocab closed 2 months ago

carlocab commented 11 months ago

The semantic equivalent of $ORIGIN on macOS is @loader_path. That seems to be the intent here, so let's use @loader_path instead of @rpath.

Setting an RPATH of @rpath is, in any case, non-sensical. An @rpath reference tells dyld (the dynamic loader) to use the known RPATHs to resolve the reference, so adding @rpath to the list of known RPATHs doesn't give dyld any more information than it already has.

freibold commented 2 months ago

Thanks for the PR! This was merged into our internal devel branch and released with an earlier Embree release.

carlocab commented 2 months ago

Thanks!