search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.74k stars 160 forks source link

New Intel TBB requirement breaks OpenVDB #109

Closed Dade916 closed 3 years ago

Dade916 commented 3 years ago

The new Intel TBB, required both by OIDN and Embree, breaks the compatibility with the past. In particular, it breaks OpenVDB compilation. As far as I know, OpenVDB (even the latest v8.x) compiles only with the old (pre-OneAPI ?) version.

This makes impossible to ship a single TBB version with the latest OIDN/Embree for anyone using OpenVDB: LuxCoreRender, Blender, etc.

P.S. I know this isn't strictly ODIN problem but TBB/ODIN/Embree/OpenVDB should a bit coordinate their efforts to avoid this kind of problem because they are very likely to be used all together.

atafra commented 3 years ago

There might be a misunderstanding here. OIDN and Embree still do not require the new oneTBB, it's only the official binaries that use the latest oneTBB. It's difficult to pick a TBB version that is used by so many different libraries anyway, so the easiest solution is to rebuild these libraries with your preferred version of TBB. AFAIK this is what Blender and probably many other applications are doing.

Dade916 commented 3 years ago

Ok, thanks. I can use two different TBB DLL versions on Linux, we are checking if it is possible on other OS. If we can't, we will compile Embree/ODIN from the sources as backup option.