RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.74k stars 160 forks source link

Add support for MPS #138

Closed Developer-Ecosystem-Engineering closed 1 year ago

Developer-Ecosystem-Engineering commented 2 years ago

We've added support for OIDN_MPS on configurations where MPS is available. This results in at least a 10x performance improvement over CPU only

Test Results

On a 2.6 GHz 6-Core Intel Core i7 with AMD Radeon Pro 5600M

RT.hdr_alb_nrm.1920x1080 ... 1058.66 (145.004) msec/image RT.ldr_alb_nrm.1920x1080 ... 1086.15 (144.358) msec/image RT.hdr_alb_nrm.3840x2160 ... 4518.11 (614.316) msec/image RT.ldr_alb_nrm.3840x2160 ... 4495.98 (608.582) msec/image RT.hdr_alb_nrm.1280x720 ... 468.137 (66.82) msec/image RT.ldr_alb_nrm.1280x720 ... 470.525 (65.8203) msec/image RTLightmap.hdr.2048x2048 ... 2045.76 (234.115) msec/image RTLightmap.hdr.4096x4096 ... 9731.88 (1021.19) msec/image RTLightmap.hdr.1024x1024 ... 544.029 (58.3557) msec/image

ghost commented 1 year ago

a "pixel-perfect" PR.

@atafra, why is this not even getting a comment?

ghost commented 1 year ago

a "pixel-perfect" PR.

@Developer-Ecosystem-Engineering , while the speedtests impress, having all changes within one commit makes the review difficult.

I would split this down into multiple commits.

atafra commented 1 year ago

@abebeos This will be available in the upcoming Open Image Denoise 2.0.

ghost commented 1 year ago

@abebeos This will be available in the upcoming Open Image Denoise 2.0.

Nice. Where can one follow the development? And do you have an estimated release date?

atafra commented 1 year ago

The development for 2.0 is currently internal. It is planned to be released in about a month.

altaic commented 7 months ago

@abebeos This will be available in the upcoming Open Image Denoise 2.0.

The development for 2.0 is currently internal. It is planned to be released in about a month.

@atafra Did this ever make it into a release?

atafra commented 7 months ago

Not yet but it will be released very soon now.