search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.78k stars 164 forks source link

Add Bazel Support #144

Closed Vertexwahn closed 1 year ago

Vertexwahn commented 1 year ago

Attempt to add Bazel build support.

atafra commented 1 year ago

Sorry but we can't commit to support another build system in addition to CMake.

Vertexwahn commented 1 year ago

It's still only a draft - but anyways good to get the feedback this early ;) - will then create rules_odin (similar as I did for https://github.com/Vertexwahn/rules_embree)

Vertexwahn commented 1 year ago

As promised here are my Bazel rules for oidn: https://github.com/Vertexwahn/rules_oidn/commits/main Please note using Bazel you have the advantage that third party dependencies such as ispc are fetched automatically! Magic!

ghost commented 1 year ago

Please note using Bazel you have the advantage that third party dependencies such as ispc are fetched automatically! Magic!

This is not relevant. You need to provide convincing rationales so the team can decide positively about at least including the changes that will allow building with Bazel.

Convince me (a neutral outsider/observer) first, see https://github.com/Vertexwahn/rules_oidn/issues/3