Support for ispc-1.18.1 planned?

Pro-pra commented 1 year ago

subj

Vertexwahn commented 1 year ago

@Pro-pra Do you see any specific problems when using ISPC 1.18.1 instead of ISPC 1.18.0? As far as I understand you only have to set ISPC_EXECUTABLE to the ISPC 1.18.1 binary and it should work.

atafra commented 1 year ago

I haven’t tried yet but it should most likely work.

From: Vertexwahn @.> Sent: Saturday, February 25, 2023 2:32 AM To: OpenImageDenoise/oidn @.> Cc: Subscribed @.***> Subject: Re: [OpenImageDenoise/oidn] Support for ispc-1.18.1 planned? (Issue #153)

Do you see any specific problems when using ISPC 1.18.1 instead of ISPC 1.18.0? As far as I understand you only have to set ISPC_EXECUTABLE to the ISPC 1.18.1 binary and it should work.

— Reply to this email directly, view it on GitHubhttps://github.com/OpenImageDenoise/oidn/issues/153#issuecomment-1444802079, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA66X7Y47NH4KFC64EASPJLWZFHH3ANCNFSM6AAAAAAVFQZLDM. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

Pro-pra commented 1 year ago

My build with ispc-1.18.1 fail with errors:

make[2]: Leaving directory '/builddir/build/BUILD/oidn-1.4.3/build'
stdlib.ispc:714:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa2_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform) 

stdlib.ispc:717:73: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos2_float" only considering exact matches. 
        Passed types: (varying float, varying float, uniform float * uniform) 

stdlib.ispc:721:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa3_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform, varying float * uniform) 

stdlib.ispc:724:83: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos3_float" only considering exact matches. 
        Passed types: (varying float, varying float, varying float, uniform 
        float * uniform) 

stdlib.ispc:728:5: Error: Unable to find any matching overload for call to 
        function "__aos_to_soa4_float" only considering exact matches. 
        Passed types: (uniform float * uniform, varying float * uniform, 
        varying float * uniform, varying float * uniform, varying float * 
        uniform) 

stdlib.ispc:732:5: Error: Unable to find any matching overload for call to 
        function "__soa_to_aos4_float" only considering exact matches. 
        Passed types: (varying float, varying float, varying float, varying 
        float, uniform float * uniform)