Open bruvzg opened 11 months ago
Bump :slightly_smiling_face: Any interest in reviewing this? This would make it possible for Godot to use OIDN as a library, as opposed to calling its oidnDenoise
CLI (which doesn't have a stable interface).
Sorry, there is interest but so far we had other priorities. We need to look into this carefully because it might have some security implications as well.
@bruvzg - Could you provide specific details about the problem you're addressing? It would be helpful if you could show the exact location of the DLLs mentioned in the description.
Fixes loading of the module library dependencies when OIDN main library is dynamically loaded at runtime, and libraries are not in the executable directory.
e.g., when app dynamically load
OpenImageDenoise.dll
at runtime, using absolute path, ModuleLoader attempts to loadOpenImageDenoise_device_cpu.dll
module, but it fails sincetbb12.dll
is not in the library search path. This change temporary adds the module library directory to the search path to ensure dependencies are loaded correctly.