search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.77k stars 164 forks source link

Hdr Issue #18

Closed royhirshkowitz closed 5 years ago

royhirshkowitz commented 5 years ago

Tonemapped ldr images are working very nicely. My first attempt at denoising hdr is failing.
No errors reported but resulting data contains invalid floats (inf, ind, NaN, etc.) Pfm file below appears to fail in my code and in the denoise sample app. Units are cd/m^2.

win64 (Windows 10). Using prebuilt OpenImageDenoise.dll.

Example pfm

atafra commented 5 years ago

The issue was caused by infinities in the input, which were not filtered out correctly by the library. A fix has been committed to the devel branch and will be available in the next release. Meanwhile please rebuild the library from source or you could also avoid the issue by making sure that the input does not contain any infinities or NaNs. Thanks!

royhirshkowitz commented 5 years ago

Cleaned up the garbage on my end and it worked like a charm. Thanks.