RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.73k stars 160 forks source link

Set TileAlignment and TileOverlap methods not implemented #184

Closed BigFranklin1 closed 7 months ago

BigFranklin1 commented 7 months ago

The UNetFilter::setInt method only handles quality and maxMemoryMB. While the TileAlignment and TileOverlap are passed in, it goes to the warning that unknown filter parameter or type mismatch.

atafra commented 7 months ago

This isn't a bug. The tileAlignment and tileOverlap are constants, and the documentation lists these as such. These are specific to the denoising algorithm and cannot be changed.

BigFranklin1 commented 7 months ago

Hi atafra! Thank you for your quick reply! I did not notice that tileAlignment is labeled as constant in the manual. The manual says that "when manually denoising in tiles....", does it mean that I can specify these params for a better performance in any situation?

image

atafra commented 7 months ago

You cannot specify these because they are specific to the denoising algorithm. This is why they are constants. But you can query these if you need to denoise a large image in tiles without relying on OIDN to do it transparently (e.g. if you want to denoise different parts of the image on different machines). You need to know these values to denoise the image correctly this way.