search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.81k stars 164 forks source link

Results coming from versions 1.X were sharper #200

Open FrankEscobar opened 9 months ago

FrankEscobar commented 9 months ago

Hello all and thank you for your work Attila!

I've found that images denoised with older versions were sharper, is that something that other people has notice that too?

1X 2X

Comparative: comparative

atafra commented 9 months ago

Hi. No, in general this shouldn't be the case but exceptions like this can always happen. In general, quality has been improved since 1.x, which can be measured using various quality metrics as well.

The filters in OIDN have been updated multiple times in both 1.x and 2.x versions, so it's unclear which actual versions you tested. Also, are you pre-filtering the albedo and normal buffers to maximize sharpness and image quality?

In this particular case, it's also a bit hard to say which version is actually closer to the ground truth. The additional sharpness in your 1.x image looks a bit like residual noise.

FrankEscobar commented 9 months ago

Since my buffers were already pretty clean it makes no difference

atafra commented 9 months ago

If this is the case, are you using the cleanAux filter option?

FrankEscobar commented 9 months ago

This was with cleanAux activated that makes a bit better result that without cleanAux.

The weird thing is that this is coming from a wall detail but the floor has more detail than before.

atafra commented 9 months ago

It's actually not that weird because even though the overall quality is higher, it's not possible to guarantee that in all cases there won't be any slight variations in quality. This seems to be such a case.