Restore hip_free call (fix crash on hip)

RenderKit / oidn

Intel® Open Image Denoise library

https://www.openimagedenoise.org/

Apache License 2.0

1.78k stars 164 forks source link

Restore hip_free call (fix crash on hip) #212

Open feniksa opened 5 months ago

feniksa commented 5 months ago

Fix crash with hip backend. HIP SDK version ROCm 5.7.1

atafra commented 5 months ago

I don't think it's safe to generally enable this hipFree call. The crash might have been fixed in newer versions of the HIP runtime but some users might still have an older driver with the bug.

feniksa commented 5 months ago

@atafra Theoretically, it is possible to check hip version before hipFree call. But I am not sure, if this is correct approach