search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.77k stars 164 forks source link

shared-lib-calls-exit #24

Closed luyatshimbalanga closed 5 years ago

luyatshimbalanga commented 5 years ago

I currently submit oidn 0.8.2 package for Fedora under review and the reviewer reported this issue with that snippet:

shared-lib-calls-exit /usr/lib64/libOpenImageDenoise.so.0.8.2 exit@GLIBC_2.2.5
shared-lib-calls-exit:
This library package calls exit() or _exit(), probably in a non-fork()
context. Doing so from a library is strongly discouraged - when a library
function calls exit(), it prevents the calling program from handling the
error, reporting it to the user, closing files properly, and cleaning up any
state that the program has. It is preferred for the library to return an
actual error code and let the calling program decide how to handle the
situation.
atafra commented 5 years ago

Fixed in v0.9.0.

luyatshimbalanga commented 5 years ago

Thank you for the fix.