search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.77k stars 164 forks source link

GPU support? #37

Closed ivalylo closed 5 years ago

ivalylo commented 5 years ago

Are there plans for Intel GPU support? MKL-DNN seems to be progressing in that direction, so I guess OIDN will also pick on that?

atafra commented 5 years ago

Yes, GPU support is planned for a future release.

ColinChargyBentley commented 4 years ago

Hi @atafra , We've well noticed that GPU support is planned for a future release and we can't wait! In the meantime, I was wondering if there are incompatibilities between oneDNN compiled with GPU support and OIDN (which are they?) or you've simply did not test this (and don't want to support it for now) ? Could you elaborate on technical challenges to overcome or change needed to allow OIDN to use GPU ?

Thank you for your answer, Regards, Colin Chargy

atafra commented 4 years ago

Hi Colin! Adding GPU support has many challenges. First, we're using a custom fork of oneDNN, so we need to port our changes to the GPU implementation as well, which is non-trivial. Also, the denoising filters have stages which cannot be performed with oneDNN and so are implemented with custom code, which also needs to be ported to the GPU.

ColinChargyBentley commented 4 years ago

Hi @atafra , Thanks for your answer. Regarding the filters stages, could we imagine have everything else done on the GPU and filters done on CPU (with the current custom code) ? Do you imagine this approach would give good results (or at least be a good first step of GPU porting) ?

Regards, Colin Chargy

atafra commented 4 years ago

No, I don't think a mixed approach would give good enough results.

ColinChargyBentley commented 4 years ago

That made perfect sense, thank you!

ahcox commented 2 years ago

Is GPU support still in progress?

atafra commented 2 years ago

Yes, it is: https://twitter.com/IntelTech/status/1435698381268025347?s=20

ColinChargy commented 2 years ago

Is it limited to Intel GPUs ?

atafra commented 2 years ago

Currently we're focusing on Intel GPUs.