search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.77k stars 164 forks source link

Pointer to const type for input images #54

Closed tomilov closed 1 year ago

tomilov commented 4 years ago

Set proper const void * instead of void * for read-only input data here.

atafra commented 4 years ago

Images are not necessarily read-only input data. Output images are also set with this function.

tomilov commented 4 years ago

@atafra it is not an excuse for a violation of const-correctness. I suggest to add const void * overloading. Currently there is the only workaround: to use const_cast. Just because the API is poor in this place.