search

RenderKit / oidn

Intel® Open Image Denoise library
https://www.openimagedenoise.org/
Apache License 2.0
1.77k stars 164 forks source link

open-image-denoise 1.2.0 failed to build on osx #63

Closed chenrui333 closed 4 years ago

chenrui333 commented 4 years ago

relates to https://github.com/Homebrew/homebrew-core/pull/52943

error log:

-- Found Threads: TRUE  
-- Found TBB: /usr/local/include  
-- Threading Building Blocks (TBB) with minimum version 2017.0 not found. (missing: TBB_DEBUG_LIBRARY TBB_DEBUG_LIBRARY_MALLOC) 
********************************************
Could not find ISPC (looked in PATH and /tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-macOS;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-macOS/bin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-osx;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-osx/bin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-Darwin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-1.12.0-Darwin/bin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-macOS;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-macOS/bin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-osx;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-osx/bin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-Darwin;/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../ispc-v1.12.0-Darwin/bin)

This version of Intel(R) Open Image Denoise expects you to have a binary install of ISPC minimum version 1.12.0, and expects it to be found in 'PATH' or in the sibling directory to where the Intel Open Image Denoise sources are located. Please go to https://ispc.github.io/downloads.html, select the binary release for your particular platform, and unpack it to /tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/../

If you insist on using your own custom install of ISPC, please make sure that the 'ISPC_EXECUTABLE' variable is properly set in CMake.
********************************************
CMake Error at cmake/oidn_ispc.cmake:41 (message):
  Could not find ISPC.  Exiting.
Call Stack (most recent call first):
  CMakeLists.txt:88 (include)

-- Configuring incomplete, errors occurred!
See also "/tmp/open-image-denoise-20200412-16916-73iojy/oidn-1.2.0/build/CMakeFiles/CMakeOutput.log".
atafra commented 4 years ago

As the error logs says, you need TBB 2017 or later and ISPC 1.12 or later to build Open Image Denoise. Do you have these installed? Thanks!

atafra commented 4 years ago

Do you have any updates on this issue? Thanks!

melMass commented 4 years ago

On mac just use the script from this repo:

cd $OIDN_REPO
./scripts/download_tbb.sh
cd build_release
cmake ..
...
chenrui333 commented 4 years ago

yeah, actually this is no longer an issue, added ispc dependency and ispc 1.13 compatibility patch, it builds fine at homebrew side (https://github.com/Homebrew/homebrew-core/pull/52943/commits/9a2cb12537f9fa6da46afe607b7826d7e256a2c9).

Closing the issue now.